-
Notifications
You must be signed in to change notification settings - Fork 1k
gtk-ng: add "title bar styles" #8166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gtk-ng: add "title bar styles" #8166
Conversation
can we unify |
IMHO, no. The default for We'd need to rethink how all of these interact to give people the effect that they are looking for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a red review so I can review before merge. Thanks
Maybe something to rethink for 1.2 and just slide on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, got a real review in. Clean!
I agree with jcollie: no... for now at least. I think GUI systems across platforms are distinct enough that unifying styling configuration is going to be a challenge in addition to I think probably just not being desirable. I think the configuration quirks per platform are too vast (there'd be too many "asterisks" on each option) and stylistically it doesn't make sense to support every style on every platform because they just culturally are different in style. |
99af57d
to
3db1934
Compare
4a12775
to
63fb2cd
Compare
This PR adds a "tabs" title bar style similar to the macOS title bar style. When `gtk-titlebar-style=tabs` the title bar and the tab bar will be merged together. The config entry for controlling this is kept separate from macOS as macOS has more styles defined that don't map to a GTK title bar style and it's likely that users that use both macOS and GTK would want different settings for each platform.
63fb2cd
to
0f67282
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified Valgrind on my end
This PR adds a "tabs" title bar style similar to the macOS title bar style. When
gtk-titlebar-style=tabs
the title bar and the tab bar will be merged together.The config entry for controlling this is kept separate from macOS as macOS has more styles defined that don't map to a GTK title bar style and it's likely that users that use both macOS and GTK would want different settings for each platform.