test(naga): assert error for ImageStore type mismatch #8494
+52
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#7023
Description
Adds the test to
tests/naga/validation.rs, as this seemed to be the simplest way to do it (though I'm new to the codebase). Seems like naga snapshot tests are currently only parsing (not validating) and are not handling (validation) errors (ref).Testing
Squash or Rebase?
Squash would be easier if more commits follow, but I'm fine with both.
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.For
cargo xtask test, on my machine a few tests fail. I think the failures shouldn't be due to the changes in this PR which only affects items private totests/naga/validation.rs.