Skip to content

Conversation

@mdtro
Copy link
Contributor

@mdtro mdtro commented Mar 14, 2024

In support of: #65941

Adds an index for the hashed_token column on ApiTokenReplica.

@mdtro mdtro requested a review from a team as a code owner March 14, 2024 10:42
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 14, 2024
@github-actions
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/hybridcloud/migrations/0015_apitokenreplica_hashed_token_index.py ()

--
-- Create index hybridcloud_hashed__a93a8b_idx on field(s) hashed_token of model apitokenreplica
--
CREATE INDEX CONCURRENTLY "hybridcloud_hashed__a93a8b_idx" ON "hybridcloud_apitokenreplica" ("hashed_token");

@codecov
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (e9d1973) to head (698445d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #66947      +/-   ##
==========================================
- Coverage   84.31%   84.31%   -0.01%     
==========================================
  Files        5309     5310       +1     
  Lines      237399   237405       +6     
  Branches    41058    41058              
==========================================
+ Hits       200172   200176       +4     
- Misses      37009    37011       +2     
  Partials      218      218              
Files Coverage Δ
...rations/0015_apitokenreplica_hashed_token_index.py 100.00% <100.00%> (ø)
src/sentry/hybridcloud/models/apitokenreplica.py 97.50% <100.00%> (ø)

... and 9 files with indirect coverage changes

@mdtro mdtro force-pushed the mdtro/apitokenreplica-index branch from 156f014 to 698445d Compare March 14, 2024 12:23
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 14, 2024
@mdtro mdtro force-pushed the mdtro/apitokenreplica-index branch from 43231bc to 698445d Compare March 14, 2024 13:31
@getsentry getsentry deleted a comment from github-actions bot Mar 14, 2024
@mdtro mdtro removed the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 14, 2024
@mdtro mdtro merged commit a806379 into master Mar 14, 2024
@mdtro mdtro deleted the mdtro/apitokenreplica-index branch March 14, 2024 15:10
JonasBa pushed a commit that referenced this pull request Mar 17, 2024
In support of: #65941

Adds an index for the `hashed_token` column on `ApiTokenReplica`.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants