Skip to content

Conversation

@antonpirker
Copy link
Contributor

@antonpirker antonpirker commented Jan 22, 2024

Cleaning up existing code to make the refactoring of Hubs and Scopes easier. (See getsentry/rfcs#122)

If this dogfooding will not raise any issues, we will merge and release it in the Sentry SDK.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 22, 2024
@codecov
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c66449b) 81.37% compared to head (5a71d6c) 81.37%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #63593      +/-   ##
==========================================
- Coverage   81.37%   81.37%   -0.01%     
==========================================
  Files        5219     5219              
  Lines      231509   231509              
  Branches    40013    40013              
==========================================
- Hits       188400   188392       -8     
- Misses      37321    37328       +7     
- Partials     5788     5789       +1     

see 9 files with indirect coverage changes

@antonpirker antonpirker marked this pull request as ready for review January 22, 2024 15:02
@antonpirker antonpirker requested a review from a team as a code owner January 22, 2024 15:02
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@antonpirker antonpirker merged commit e477738 into master Jan 22, 2024
@antonpirker antonpirker deleted the antonpirker/python-sdk-cleanup-dogfooding branch January 22, 2024 15:06
isabellaenriquez pushed a commit that referenced this pull request Jan 22, 2024
Cleaning up existing code to make the refactoring of Hubs and Scopes
easier. (See getsentry/rfcs#122)

If this dogfooding will not raise any issues, we will merge and release
it in the Sentry SDK.
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants