feat(org-tokens): Adjust token format from JWT #51341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51341 +/- ##
=======================================
Coverage 81.29 81.29
=======================================
Files 4901 4901
Lines 205524 205528 +4
Branches 11081 11081
=======================================
Hits 167076 167076
- Misses 38203 38207 +4
Partials 245 245
|
mdtro
reviewed
Jun 21, 2023
mydea
force-pushed
the
fn/org-token-base64
branch
from
7164ebd to
cae757b
Compare
mdtro
reviewed
Jun 22, 2023
iambriccardo
approved these changes
Jun 23, 2023
Co-authored-by: Matthew T <[email protected]>
Co-authored-by: Matthew T <[email protected]>
mydea
force-pushed
the
fn/org-token-base64
branch
from
7ecd574 to
bef17fc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the token format of the new org auth tokens from using JWT to a custom format based on base64 encoding.
This should result in nicer endings of tokens, and also makes the tokens considerably shorter.
Related to getsentry/rfcs#105