Skip to content

test(issues): Migrate issue details header test from deprecatedRouterMocks #102525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
Merged

test(issues): Migrate issue details header test from deprecatedRouterMocks #102525

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f18d5d
test(issues): Migrate issue details header test from deprecatedRouter…
scttcper Oct 31, 2025
1384062
Merge branch 'master' into scttcper/test-issue-details-header
scttcper Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 32 additions & 68 deletions static/app/views/issueDetails/header.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {OrganizationFixture} from 'sentry-fixture/organization';
import {ProjectFixture} from 'sentry-fixture/project';
import {TeamFixture} from 'sentry-fixture/team';

import {initializeOrg} from 'sentry-test/initializeOrg';
import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';

import {mockTour} from 'sentry/components/tours/testUtils';
Expand All @@ -17,9 +16,8 @@ jest.mock('sentry/views/issueDetails/issueDetailsTour', () => ({
}));

describe('GroupHeader', () => {
const baseUrl = 'BASE_URL/';
const baseUrl = '/mock-pathname/';
const organization = OrganizationFixture();
const {router} = initializeOrg();
const project = ProjectFixture({
teams: [TeamFixture()],
});
Expand Down Expand Up @@ -53,65 +51,47 @@ describe('GroupHeader', () => {
},
});

render(
const {router} = render(
<GroupHeader
{...defaultProps}
organization={orgWithFeatures}
project={jsProjectWithSimilarityView}
/>,
{
organization: orgWithFeatures,
router,
deprecatedRouterMocks: true,
}
);

await userEvent.click(screen.getByRole('tab', {name: /details/i}));
expect(router.push).toHaveBeenLastCalledWith(
expect.objectContaining({pathname: 'BASE_URL/'})
);
const expectLocation = (pathname: string) => {
expect(router.location.pathname).toBe(pathname);
expect(router.location.query).toEqual({});
};

expectLocation(`${baseUrl}`);

await userEvent.click(screen.getByRole('tab', {name: /activity/i}));
expect(router.push).toHaveBeenCalledWith({
pathname: 'BASE_URL/activity/',
query: {},
});
expectLocation(`${baseUrl}activity/`);

await userEvent.click(screen.getByRole('tab', {name: /user feedback/i}));
expect(router.push).toHaveBeenCalledWith({
pathname: 'BASE_URL/feedback/',
query: {},
});
expectLocation(`${baseUrl}feedback/`);

await userEvent.click(screen.getByRole('tab', {name: /attachments/i}));
expect(router.push).toHaveBeenCalledWith({
pathname: 'BASE_URL/attachments/',
query: {},
});
expectLocation(`${baseUrl}attachments/`);

await userEvent.click(screen.getByRole('tab', {name: /tags/i}));
expect(router.push).toHaveBeenCalledWith({
pathname: 'BASE_URL/distributions/',
query: {},
});
expectLocation(`${baseUrl}distributions/`);

await userEvent.click(screen.getByRole('tab', {name: /all events/i}));
expect(router.push).toHaveBeenCalledWith({
pathname: 'BASE_URL/events/',
query: {},
});
expectLocation(`${baseUrl}events/`);

await userEvent.click(screen.getByRole('tab', {name: /merged issues/i}));
expect(router.push).toHaveBeenCalledWith({
pathname: 'BASE_URL/merged/',
query: {},
});
expectLocation(`${baseUrl}merged/`);

await userEvent.click(screen.getByRole('tab', {name: /replays/i}));
expect(router.push).toHaveBeenCalledWith({
pathname: 'BASE_URL/replays/',
query: {},
});
expectLocation(`${baseUrl}replays/`);

await userEvent.click(screen.getByRole('tab', {name: /details/i}));
expectLocation(`${baseUrl}`);

expect(screen.getByRole('tab', {name: /replays/i})).toBeInTheDocument();
});
Expand Down Expand Up @@ -146,24 +126,20 @@ describe('GroupHeader', () => {
},
});

render(
const {router} = render(
<GroupHeader
{...defaultProps}
organization={orgWithFeatures}
project={mobileProjectWithSimilarityView}
/>,
{
organization: orgWithFeatures,
router,
deprecatedRouterMocks: true,
}
);

await userEvent.click(screen.getByRole('tab', {name: /similar issues/i}));
expect(router.push).toHaveBeenCalledWith({
pathname: 'BASE_URL/similar/',
query: {},
});
expect(router.location.pathname).toBe(`${baseUrl}similar/`);
expect(router.location.query).toEqual({});

expect(screen.queryByRole('tab', {name: /replays/i})).not.toBeInTheDocument();
});
Expand Down Expand Up @@ -198,35 +174,29 @@ describe('GroupHeader', () => {
},
});

render(
const {router} = render(
<GroupHeader
{...defaultProps}
organization={orgWithFeatures}
project={projectWithSimilarityView}
/>,
{
organization: orgWithFeatures,
router,
deprecatedRouterMocks: true,
}
);

await userEvent.click(screen.getByRole('tab', {name: /details/i}));
expect(router.push).toHaveBeenLastCalledWith(
expect.objectContaining({pathname: 'BASE_URL/'})
);
const expectLocation = (pathname: string) => {
expect(router.location.pathname).toBe(pathname);
expect(router.location.query).toEqual({});
};

expectLocation(`${baseUrl}`);

await userEvent.click(screen.getByRole('tab', {name: /tags/i}));
expect(router.push).toHaveBeenCalledWith({
pathname: 'BASE_URL/distributions/',
query: {},
});
expectLocation(`${baseUrl}distributions/`);

await userEvent.click(screen.getByRole('tab', {name: /sampled events/i}));
expect(router.push).toHaveBeenCalledWith({
pathname: 'BASE_URL/events/',
query: {},
});
expectLocation(`${baseUrl}events/`);

expect(screen.queryByRole('tab', {name: /user feedback/i})).not.toBeInTheDocument();
expect(screen.queryByRole('tab', {name: /attachments/i})).not.toBeInTheDocument();
Expand Down Expand Up @@ -262,10 +232,7 @@ describe('GroupHeader', () => {
})}
project={ProjectFixture()}
event={null}
/>,
{
deprecatedRouterMocks: true,
}
/>
);

expect(await screen.findByText('Priority')).toBeInTheDocument();
Expand All @@ -286,10 +253,7 @@ describe('GroupHeader', () => {
group={GroupFixture({priority: PriorityLevel.MEDIUM})}
project={ProjectFixture()}
event={null}
/>,
{
deprecatedRouterMocks: true,
}
/>
);

await userEvent.click(screen.getByRole('button', {name: 'Modify issue priority'}));
Expand Down
Loading