DNM feat(preprod): Add distribution:read scope #101411
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
chromy
force-pushed
the
chromy/2025-10-13-add-scope
branch
from
eb3f9e9 to
a7ad7e6
Compare
chromy
force-pushed
the
chromy/2025-10-13-add-scope
branch
from
a7ad7e6 to
f28420c
Compare
noahsmartin
reviewed
Oct 14, 2025
|
|
||
| class ProjectDistributionPermission(ProjectPermission): | ||
| scope_map = { | ||
| "GET": ["project:read", "project:write", "project:admin", "distribution:read", "org:ci"], |
There was a problem hiding this comment.
I was thinking we exclude all the scopes other than "distribution:read". Do we need the other ones? This token wouldn't be used for anything other than GET
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.