Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Nov 11, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Breaking changes:

SubPRs:

💡 Motivation and Context

See #5273

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@antonis
Copy link
Contributor Author

antonis commented Nov 11, 2025

Marking as Blocked while the Cocoa v9 is in Alpha

itaybre and others added 3 commits November 11, 2025 16:38
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

---------

Co-authored-by: Antonis Lilis <[email protected]>
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

---------

Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Antonis Lilis <[email protected]>
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

---------

Co-authored-by: Antonis Lilis <[email protected]>
Co-authored-by: Denis Andrasec <[email protected]>
Co-authored-by: Noah Martin <[email protected]>
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 11, 2025
@antonis
Copy link
Contributor Author

antonis commented Nov 11, 2025

Adding the ready-to-merge label to trigger all tests but it's not really ready to merge 😅

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 597.51 ms 634.22 ms 36.71 ms
Size 43.94 MiB 48.90 MiB 4.96 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0b64753+dirty 358.55 ms 429.16 ms 70.61 ms
c9e95bd+dirty 339.32 ms 401.24 ms 61.92 ms
90e7cb3+dirty 415.17 ms 458.48 ms 43.31 ms
a941c72+dirty 381.92 ms 436.63 ms 54.71 ms
ee69ed5+dirty 411.19 ms 447.04 ms 35.85 ms
818a608+dirty 350.29 ms 397.38 ms 47.09 ms
ea3e26e+dirty 399.98 ms 448.36 ms 48.38 ms
af9331b+dirty 374.42 ms 425.68 ms 51.26 ms
07808fb+dirty 392.47 ms 451.94 ms 59.47 ms
d861c16+dirty 334.54 ms 339.27 ms 4.72 ms

App size

Revision Plain With Sentry Diff
0b64753+dirty 7.15 MiB 8.42 MiB 1.27 MiB
c9e95bd+dirty 7.15 MiB 8.41 MiB 1.26 MiB
90e7cb3+dirty 43.94 MiB 48.85 MiB 4.91 MiB
a941c72+dirty 43.94 MiB 48.87 MiB 4.93 MiB
ee69ed5+dirty 43.94 MiB 48.87 MiB 4.93 MiB
818a608+dirty 7.15 MiB 8.41 MiB 1.26 MiB
ea3e26e+dirty 43.94 MiB 48.82 MiB 4.88 MiB
af9331b+dirty 7.15 MiB 8.41 MiB 1.26 MiB
07808fb+dirty 7.15 MiB 8.43 MiB 1.28 MiB
d861c16+dirty 7.15 MiB 8.43 MiB 1.28 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 464.02 ms 490.62 ms 26.60 ms
Size 43.75 MiB 48.07 MiB 4.32 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3312430+dirty 362.54 ms 368.76 ms 6.22 ms
c9e95bd 428.04 ms 458.70 ms 30.65 ms
90e7cb3+dirty 470.65 ms 499.08 ms 28.43 ms
a941c72+dirty 489.85 ms 549.17 ms 59.32 ms
ee69ed5+dirty 409.44 ms 441.30 ms 31.86 ms
ea3e26e+dirty 498.02 ms 532.90 ms 34.88 ms
ff5a06a+dirty 405.97 ms 439.24 ms 33.27 ms
1ef8a04+dirty 415.16 ms 415.22 ms 0.06 ms
526494a+dirty 422.80 ms 438.90 ms 16.10 ms
4a17c8f+dirty 406.62 ms 400.58 ms -6.04 ms

App size

Revision Plain With Sentry Diff
3312430+dirty 17.75 MiB 19.75 MiB 2.00 MiB
c9e95bd 17.75 MiB 19.68 MiB 1.93 MiB
90e7cb3+dirty 43.75 MiB 48.02 MiB 4.27 MiB
a941c72+dirty 43.75 MiB 48.05 MiB 4.29 MiB
ee69ed5+dirty 43.75 MiB 48.04 MiB 4.29 MiB
ea3e26e+dirty 43.75 MiB 47.99 MiB 4.24 MiB
ff5a06a+dirty 43.75 MiB 48.05 MiB 4.29 MiB
1ef8a04+dirty 43.75 MiB 48.05 MiB 4.29 MiB
526494a+dirty 43.75 MiB 47.99 MiB 4.24 MiB
4a17c8f+dirty 43.75 MiB 47.99 MiB 4.24 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.00 ms 1212.65 ms -4.35 ms
Size 3.41 MiB 4.74 MiB 1.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0b64753+dirty 1225.77 ms 1232.98 ms 7.21 ms
5602cc4+dirty 1204.83 ms 1212.47 ms 7.64 ms
eec00c2+dirty 1210.90 ms 1211.13 ms 0.23 ms
a31630c+dirty 1241.32 ms 1226.98 ms -14.34 ms
bfe454a+dirty 1231.82 ms 1239.98 ms 8.16 ms
64cd15c+dirty 1213.50 ms 1223.54 ms 10.04 ms
20d5eaa+dirty 1224.67 ms 1223.16 ms -1.51 ms
98f632c+dirty 1221.38 ms 1229.26 ms 7.88 ms
5c16cdc+dirty 1235.67 ms 1241.18 ms 5.51 ms
e76d0d3+dirty 1229.94 ms 1228.04 ms -1.90 ms

App size

Revision Plain With Sentry Diff
0b64753+dirty 3.19 MiB 4.55 MiB 1.36 MiB
5602cc4+dirty 3.41 MiB 4.67 MiB 1.25 MiB
eec00c2+dirty 3.41 MiB 4.59 MiB 1.18 MiB
a31630c+dirty 3.19 MiB 4.54 MiB 1.36 MiB
bfe454a+dirty 3.19 MiB 4.54 MiB 1.36 MiB
64cd15c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
20d5eaa+dirty 3.19 MiB 4.38 MiB 1.19 MiB
98f632c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
5c16cdc+dirty 3.19 MiB 4.53 MiB 1.34 MiB
e76d0d3+dirty 3.19 MiB 4.57 MiB 1.38 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1216.96 ms 1214.32 ms -2.64 ms
Size 3.41 MiB 4.74 MiB 1.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0b64753+dirty 1232.49 ms 1226.96 ms -5.53 ms
5602cc4+dirty 1216.49 ms 1211.58 ms -4.91 ms
eec00c2+dirty 1202.92 ms 1206.38 ms 3.46 ms
a31630c+dirty 1229.09 ms 1230.94 ms 1.85 ms
bfe454a+dirty 1235.33 ms 1243.12 ms 7.79 ms
64cd15c+dirty 1216.31 ms 1214.04 ms -2.26 ms
20d5eaa+dirty 1231.12 ms 1226.00 ms -5.12 ms
98f632c+dirty 1236.40 ms 1241.62 ms 5.22 ms
5c16cdc+dirty 1209.32 ms 1210.67 ms 1.35 ms
e76d0d3+dirty 1223.04 ms 1216.80 ms -6.24 ms

App size

Revision Plain With Sentry Diff
0b64753+dirty 2.63 MiB 3.98 MiB 1.35 MiB
5602cc4+dirty 3.41 MiB 4.67 MiB 1.25 MiB
eec00c2+dirty 3.41 MiB 4.59 MiB 1.18 MiB
a31630c+dirty 2.63 MiB 3.98 MiB 1.34 MiB
bfe454a+dirty 2.63 MiB 3.98 MiB 1.34 MiB
64cd15c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
20d5eaa+dirty 2.63 MiB 3.81 MiB 1.18 MiB
98f632c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
5c16cdc+dirty 2.63 MiB 3.96 MiB 1.33 MiB
e76d0d3+dirty 2.63 MiB 4.00 MiB 1.37 MiB

@antonis antonis changed the title chore(deps): update Cocoa SDK to v9.0.0-alpha.0 chore(deps): update Cocoa SDK to v9.0.0-alpha Nov 13, 2025
@antonis
Copy link
Contributor Author

antonis commented Nov 13, 2025

fix(podspec): Cocoa V9 allow any alpha version

Thank you @philipphofmann 🦸

antonis and others added 2 commits November 13, 2025 12:00
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

* chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9

---------

Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Denis Andrasec <[email protected]>
Co-authored-by: Noah Martin <[email protected]>
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

* chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9

* chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0

* Bump to 15.1 due to RN 0.81.0 requirements

---------

Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Denis Andrasec <[email protected]>
Co-authored-by: Noah Martin <[email protected]>
@antonis antonis removed the ready-to-merge Triggers the full CI test suite label Nov 13, 2025
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 13, 2025
@antonis antonis changed the title chore(deps): update Cocoa SDK to v9.0.0-alpha chore(deps): update Cocoa SDK to v9.0.0-rc Nov 24, 2025
@antonis antonis changed the title chore(deps): update Cocoa SDK to v9.0.0-rc chore(deps): update Cocoa SDK to v9.0.0 GA Dec 1, 2025
@lucas-zimerman
Copy link
Collaborator

V9 was released so I will unblock this issue

@antonis
Copy link
Contributor Author

antonis commented Dec 3, 2025

V9 was released so I will unblock this issue

Correct. I'll keep it in draft for now since we are not going to merge on the main branch but on v8.

I've also opened getsentry/sentry-cocoa#6942 that I hope is going to fix some of the issues

@antonis antonis changed the title chore(deps): update Cocoa SDK to v9.0.0 GA chore(deps): update Cocoa SDK to v9 Dec 11, 2025
@antonis antonis removed the ready-to-merge Triggers the full CI test suite label Dec 11, 2025
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Dec 11, 2025
@antonis
Copy link
Contributor Author

antonis commented Dec 11, 2025

The CI is 🟢 again with 9.1.0 and the current issues are solved. The sample app also behaved as expected in my manual tests 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants