fix(android): Pass enabled option to native #5334

antonis · 2025-11-05T16:11:05Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Passes enabled option to the Android SDK
On iOS the option is already there

💡 Motivation and Context

Fixes #4247

💚 How did you test it?

CI, Manual testing with the sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2025-11-05T16:33:13Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	368.23 ms	416.96 ms	48.72 ms
Size	43.94 MiB	48.82 MiB	4.88 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e2fa43d`+dirty	326.56 ms	372.88 ms	46.32 ms
`90edad7`+dirty	372.57 ms	398.83 ms	26.26 ms
`8ece263`+dirty	369.44 ms	414.65 ms	45.21 ms
`21c9e75`+dirty	356.73 ms	381.06 ms	24.33 ms
`276d348`+dirty	356.30 ms	405.27 ms	48.97 ms
`534ba8c`+dirty	472.35 ms	537.31 ms	64.96 ms
`af9331b`+dirty	374.42 ms	425.68 ms	51.26 ms
`95aaf8a`+dirty	342.82 ms	393.75 ms	50.93 ms
`c7f264b`+dirty	356.98 ms	407.46 ms	50.48 ms
`49ef936`+dirty	333.72 ms	387.51 ms	53.79 ms

App size

Revision	Plain	With Sentry	Diff
`e2fa43d`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`90edad7`+dirty	7.15 MiB	8.43 MiB	1.28 MiB
`8ece263`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`21c9e75`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`276d348`+dirty	7.15 MiB	8.42 MiB	1.26 MiB
`534ba8c`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`af9331b`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`95aaf8a`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`c7f264b`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`49ef936`+dirty	7.15 MiB	8.42 MiB	1.26 MiB

Previous results on branch: antonis/pass-enabled-to-native

Startup times

Revision	Plain	With Sentry	Diff
`87c3174`+dirty	376.23 ms	406.76 ms	30.53 ms
`4ba4de2`+dirty	381.73 ms	398.90 ms	17.17 ms

App size

Revision	Plain	With Sentry	Diff
`87c3174`+dirty	43.94 MiB	48.82 MiB	4.88 MiB
`4ba4de2`+dirty	43.94 MiB	48.81 MiB	4.88 MiB

github-actions · 2025-11-05T16:34:33Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	410.51 ms	415.94 ms	5.43 ms
Size	43.75 MiB	47.99 MiB	4.24 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`2104bb9`+dirty	410.71 ms	461.52 ms	50.81 ms
`8490686`+dirty	365.59 ms	400.24 ms	34.65 ms
`5ee3314`+dirty	415.80 ms	426.14 ms	10.34 ms
`eb07ba3`	470.04 ms	473.35 ms	3.31 ms
`2b89ce9`	413.69 ms	442.58 ms	28.89 ms
`20d5eaa`	377.62 ms	406.50 ms	28.88 ms
`6fee48d`+dirty	407.42 ms	437.71 ms	30.29 ms
`a2bb688`+dirty	409.65 ms	410.45 ms	0.80 ms
`f234eb4`+dirty	407.62 ms	429.64 ms	22.02 ms
`21c9e75`	450.39 ms	452.92 ms	2.53 ms

App size

Revision	Plain	With Sentry	Diff
`2104bb9`+dirty	17.75 MiB	19.74 MiB	1.99 MiB
`8490686`+dirty	17.75 MiB	19.70 MiB	1.96 MiB
`5ee3314`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`eb07ba3`	17.75 MiB	20.15 MiB	2.41 MiB
`2b89ce9`	17.75 MiB	19.68 MiB	1.94 MiB
`20d5eaa`	17.75 MiB	20.15 MiB	2.41 MiB
`6fee48d`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`a2bb688`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`f234eb4`+dirty	17.75 MiB	19.74 MiB	1.99 MiB
`21c9e75`	17.75 MiB	20.15 MiB	2.41 MiB

Previous results on branch: antonis/pass-enabled-to-native

Startup times

Revision	Plain	With Sentry	Diff
`87c3174`+dirty	471.96 ms	507.20 ms	35.24 ms
`4ba4de2`+dirty	401.92 ms	427.08 ms	25.16 ms

App size

Revision	Plain	With Sentry	Diff
`87c3174`+dirty	43.75 MiB	47.99 MiB	4.24 MiB
`4ba4de2`+dirty	43.75 MiB	47.99 MiB	4.23 MiB

github-actions · 2025-11-05T16:39:40Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1199.65 ms	1202.98 ms	3.33 ms
Size	3.41 MiB	4.58 MiB	1.17 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`4167e15`+dirty	1228.96 ms	1242.15 ms	13.19 ms
`11ded16`+dirty	1220.84 ms	1221.60 ms	0.76 ms
`652f785`+dirty	1216.42 ms	1212.21 ms	-4.21 ms
`b7aa1aa`+dirty	1232.55 ms	1234.16 ms	1.61 ms
`1d62dde`+dirty	1204.96 ms	1208.51 ms	3.55 ms
`c4e097a`+dirty	1231.35 ms	1246.91 ms	15.56 ms
`23080e5`+dirty	1221.39 ms	1222.08 ms	0.70 ms
`ba75c7c`+dirty	1236.14 ms	1240.69 ms	4.55 ms
`49ef936`+dirty	1221.27 ms	1221.60 ms	0.34 ms
`818a608`+dirty	1218.84 ms	1223.18 ms	4.34 ms

App size

Revision	Plain	With Sentry	Diff
`4167e15`+dirty	3.19 MiB	4.57 MiB	1.38 MiB
`11ded16`+dirty	3.19 MiB	4.58 MiB	1.39 MiB
`652f785`+dirty	3.41 MiB	4.57 MiB	1.16 MiB
`b7aa1aa`+dirty	3.19 MiB	4.58 MiB	1.39 MiB
`1d62dde`+dirty	3.19 MiB	4.58 MiB	1.39 MiB
`c4e097a`+dirty	3.19 MiB	4.44 MiB	1.25 MiB
`23080e5`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`ba75c7c`+dirty	3.19 MiB	4.38 MiB	1.19 MiB
`49ef936`+dirty	3.19 MiB	4.54 MiB	1.36 MiB
`818a608`+dirty	3.19 MiB	4.48 MiB	1.29 MiB

Previous results on branch: antonis/pass-enabled-to-native

Startup times

Revision	Plain	With Sentry	Diff
`4ba4de2`+dirty	1218.65 ms	1211.66 ms	-6.99 ms
`87c3174`+dirty	1210.96 ms	1204.91 ms	-6.04 ms

App size

Revision	Plain	With Sentry	Diff
`4ba4de2`+dirty	3.41 MiB	4.57 MiB	1.16 MiB
`87c3174`+dirty	3.41 MiB	4.58 MiB	1.17 MiB

github-actions · 2025-11-05T16:41:17Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1213.87 ms	1201.73 ms	-12.14 ms
Size	3.41 MiB	4.58 MiB	1.17 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`4167e15`+dirty	1213.39 ms	1222.50 ms	9.11 ms
`11ded16`+dirty	1230.71 ms	1235.52 ms	4.81 ms
`652f785`+dirty	1219.66 ms	1223.62 ms	3.96 ms
`b7aa1aa`+dirty	1234.35 ms	1241.61 ms	7.27 ms
`1d62dde`+dirty	1214.38 ms	1223.36 ms	8.98 ms
`c4e097a`+dirty	1229.09 ms	1242.61 ms	13.53 ms
`23080e5`+dirty	1216.02 ms	1224.94 ms	8.91 ms
`ba75c7c`+dirty	1235.86 ms	1226.45 ms	-9.41 ms
`49ef936`+dirty	1228.42 ms	1217.09 ms	-11.33 ms
`818a608`+dirty	1205.76 ms	1208.00 ms	2.24 ms

App size

Revision	Plain	With Sentry	Diff
`4167e15`+dirty	2.63 MiB	4.00 MiB	1.37 MiB
`11ded16`+dirty	2.63 MiB	4.01 MiB	1.38 MiB
`652f785`+dirty	3.41 MiB	4.57 MiB	1.16 MiB
`b7aa1aa`+dirty	2.63 MiB	4.01 MiB	1.38 MiB
`1d62dde`+dirty	2.63 MiB	4.01 MiB	1.38 MiB
`c4e097a`+dirty	2.63 MiB	3.87 MiB	1.24 MiB
`23080e5`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`ba75c7c`+dirty	2.63 MiB	3.81 MiB	1.18 MiB
`49ef936`+dirty	2.63 MiB	3.98 MiB	1.34 MiB
`818a608`+dirty	2.63 MiB	3.91 MiB	1.28 MiB

Previous results on branch: antonis/pass-enabled-to-native

Startup times

Revision	Plain	With Sentry	Diff
`4ba4de2`+dirty	1215.88 ms	1215.29 ms	-0.59 ms
`87c3174`+dirty	1204.76 ms	1208.13 ms	3.37 ms

App size

Revision	Plain	With Sentry	Diff
`4ba4de2`+dirty	3.41 MiB	4.57 MiB	1.16 MiB
`87c3174`+dirty	3.41 MiB	4.58 MiB	1.17 MiB

CHANGELOG.md

lucas-zimerman

After deciding on the changelog title, LGTM!

Co-authored-by: LucasZF <[email protected]>

antonis added 2 commits November 5, 2025 17:08

fix(android): Pass enabled option to native

6a7aed7

Add changelog

0c24c98

antonis marked this pull request as ready for review November 5, 2025 16:15

antonis requested review from alwx and lucas-zimerman as code owners November 5, 2025 16:15

Merge branch 'main' into antonis/pass-enabled-to-native

c058ffb

lucas-zimerman reviewed Nov 6, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

lucas-zimerman approved these changes Nov 6, 2025

View reviewed changes

lucas-zimerman mentioned this pull request Nov 6, 2025

Sync RN Change for disabling Native SDKS from Sentry Options. getsentry/sentry-capacitor#1029

Open

Update CHANGELOG.md

5eef95a

Co-authored-by: LucasZF <[email protected]>

antonis enabled auto-merge (squash) November 6, 2025 13:40

antonis merged commit d1bfbde into main Nov 6, 2025
65 checks passed

antonis deleted the antonis/pass-enabled-to-native branch November 6, 2025 13:43

Uh oh!

fix(android): Pass enabled option to native #5334

fix(android): Pass enabled option to native #5334

Uh oh!

Conversation

antonis commented Nov 5, 2025 • edited by lucas-zimerman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/pass-enabled-to-native

Startup times

App size

Uh oh!

github-actions bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/pass-enabled-to-native

Startup times

App size

Uh oh!

github-actions bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/pass-enabled-to-native

Startup times

App size

Uh oh!

github-actions bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/pass-enabled-to-native

Startup times

App size

Uh oh!

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

antonis commented Nov 5, 2025 •

edited by lucas-zimerman

Loading

github-actions bot commented Nov 5, 2025 •

edited

Loading

github-actions bot commented Nov 5, 2025 •

edited

Loading

github-actions bot commented Nov 5, 2025 •

edited

Loading

github-actions bot commented Nov 5, 2025 •

edited

Loading