Skip to content

Conversation

@alwx
Copy link
Contributor

@alwx alwx commented Aug 11, 2025

Fixes #4941

Includes:

  • React Native version bump (to 0.80.2)
  • react-native-vector-icons version bump (with the updated imports)
  • updated usage of Redux (with @toolkit/redux)
  • all the individual tabs have moved to /src/tabs
  • removed the usage of Sentry.getCurrentHub() (not supported anymore because of OpenTelemetry)
  • sorted imports, code style changes
  • returned WebviewScreen which was disabled due to issues with RN 0.79
  • RCTNewArchEnabled added to Info.plist

Important things to know:

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against db46f3d

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 351.17 ms 382.69 ms 31.52 ms
Size 7.15 MiB 8.41 MiB 1.26 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
23080e5+dirty 347.29 ms 381.87 ms 34.58 ms
bc9680d+dirty 346.77 ms 463.48 ms 116.71 ms
7be1f99+dirty 369.02 ms 399.60 ms 30.58 ms
3e0a5f9+dirty 379.92 ms 450.96 ms 71.04 ms
20daa0a+dirty 352.33 ms 424.30 ms 71.98 ms
818a608+dirty 350.29 ms 397.38 ms 47.09 ms
8a4ce6f+dirty 401.11 ms 381.92 ms -19.19 ms
20d5eaa+dirty 358.31 ms 442.37 ms 84.06 ms
6479fd5+dirty 393.06 ms 434.04 ms 40.98 ms
9f211e3+dirty 371.00 ms 432.51 ms 61.51 ms

App size

Revision Plain With Sentry Diff
23080e5+dirty 7.15 MiB 8.41 MiB 1.26 MiB
bc9680d+dirty 7.15 MiB 8.42 MiB 1.27 MiB
7be1f99+dirty 7.15 MiB 8.42 MiB 1.27 MiB
3e0a5f9+dirty 7.15 MiB 8.42 MiB 1.27 MiB
20daa0a+dirty 7.15 MiB 8.42 MiB 1.27 MiB
818a608+dirty 7.15 MiB 8.41 MiB 1.26 MiB
8a4ce6f+dirty 7.15 MiB 8.41 MiB 1.26 MiB
20d5eaa+dirty 7.15 MiB 8.42 MiB 1.27 MiB
6479fd5+dirty 7.15 MiB 8.41 MiB 1.26 MiB
9f211e3+dirty 7.15 MiB 8.41 MiB 1.26 MiB

Previous results on branch: alwx/improvement/sample-apps

Startup times

Revision Plain With Sentry Diff
771e482+dirty 359.85 ms 389.50 ms 29.65 ms
58c31b1+dirty 377.34 ms 419.60 ms 42.26 ms
ab7f938+dirty 375.83 ms 436.77 ms 60.94 ms
afe6a03+dirty 388.48 ms 438.27 ms 49.79 ms
2fff661+dirty 350.33 ms 380.04 ms 29.71 ms
66f1324+dirty 368.06 ms 395.72 ms 27.66 ms

App size

Revision Plain With Sentry Diff
771e482+dirty 7.15 MiB 8.42 MiB 1.27 MiB
58c31b1+dirty 7.15 MiB 8.41 MiB 1.26 MiB
ab7f938+dirty 7.15 MiB 8.41 MiB 1.26 MiB
afe6a03+dirty 7.15 MiB 8.42 MiB 1.27 MiB
2fff661+dirty 7.15 MiB 8.41 MiB 1.26 MiB
66f1324+dirty 7.15 MiB 8.42 MiB 1.27 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.27 ms 1228.20 ms 1.93 ms
Size 2.63 MiB 3.96 MiB 1.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c9e95bd+dirty 1240.19 ms 1246.33 ms 6.14 ms
c1573b3+dirty 1203.33 ms 1202.47 ms -0.86 ms
2b89ce9+dirty 1229.30 ms 1239.40 ms 10.10 ms
7be1f99+dirty 1226.69 ms 1217.76 ms -8.93 ms
785ffb1+dirty 1237.63 ms 1240.50 ms 2.87 ms
b3b5b0d+dirty 1227.71 ms 1239.50 ms 11.79 ms
c08359e+dirty 1235.25 ms 1233.96 ms -1.29 ms
e2fa43d+dirty 1216.04 ms 1232.65 ms 16.61 ms
64cd15c+dirty 1216.31 ms 1214.04 ms -2.26 ms
8d89cc9+dirty 1222.92 ms 1239.43 ms 16.51 ms

App size

Revision Plain With Sentry Diff
c9e95bd+dirty 2.63 MiB 3.87 MiB 1.24 MiB
c1573b3+dirty 2.63 MiB 3.81 MiB 1.18 MiB
2b89ce9+dirty 2.63 MiB 3.91 MiB 1.28 MiB
7be1f99+dirty 2.63 MiB 3.81 MiB 1.18 MiB
785ffb1+dirty 2.63 MiB 3.81 MiB 1.18 MiB
b3b5b0d+dirty 2.63 MiB 3.91 MiB 1.28 MiB
c08359e+dirty 2.63 MiB 3.81 MiB 1.18 MiB
e2fa43d+dirty 2.63 MiB 3.81 MiB 1.18 MiB
64cd15c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
8d89cc9+dirty 2.63 MiB 3.96 MiB 1.33 MiB

Previous results on branch: alwx/improvement/sample-apps

Startup times

Revision Plain With Sentry Diff
771e482+dirty 1222.81 ms 1225.86 ms 3.05 ms
58c31b1+dirty 1225.92 ms 1239.06 ms 13.14 ms
2fff661+dirty 1216.84 ms 1226.06 ms 9.23 ms
ab7f938+dirty 1233.18 ms 1238.25 ms 5.07 ms
afe6a03+dirty 1219.98 ms 1233.39 ms 13.41 ms
66f1324+dirty 1230.79 ms 1235.80 ms 5.00 ms

App size

Revision Plain With Sentry Diff
771e482+dirty 2.63 MiB 3.81 MiB 1.18 MiB
58c31b1+dirty 2.63 MiB 3.96 MiB 1.33 MiB
2fff661+dirty 2.63 MiB 3.96 MiB 1.33 MiB
ab7f938+dirty 2.63 MiB 3.96 MiB 1.33 MiB
afe6a03+dirty 2.63 MiB 3.81 MiB 1.18 MiB
66f1324+dirty 2.63 MiB 3.81 MiB 1.18 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1229.18 ms 1232.63 ms 3.44 ms
Size 3.19 MiB 4.53 MiB 1.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c9e95bd+dirty 1205.83 ms 1207.38 ms 1.55 ms
c1573b3+dirty 1245.69 ms 1245.48 ms -0.21 ms
2b89ce9+dirty 1241.19 ms 1254.20 ms 13.01 ms
7be1f99+dirty 1222.43 ms 1217.15 ms -5.28 ms
785ffb1+dirty 1213.71 ms 1213.37 ms -0.35 ms
b3b5b0d+dirty 1235.16 ms 1238.61 ms 3.45 ms
c08359e+dirty 1200.59 ms 1211.81 ms 11.22 ms
e2fa43d+dirty 1224.43 ms 1235.40 ms 10.98 ms
64cd15c+dirty 1213.50 ms 1223.54 ms 10.04 ms
8d89cc9+dirty 1232.35 ms 1228.53 ms -3.82 ms

App size

Revision Plain With Sentry Diff
c9e95bd+dirty 3.19 MiB 4.44 MiB 1.25 MiB
c1573b3+dirty 3.19 MiB 4.38 MiB 1.19 MiB
2b89ce9+dirty 3.19 MiB 4.48 MiB 1.29 MiB
7be1f99+dirty 3.19 MiB 4.38 MiB 1.19 MiB
785ffb1+dirty 3.19 MiB 4.38 MiB 1.19 MiB
b3b5b0d+dirty 3.19 MiB 4.48 MiB 1.29 MiB
c08359e+dirty 3.19 MiB 4.38 MiB 1.19 MiB
e2fa43d+dirty 3.19 MiB 4.38 MiB 1.19 MiB
64cd15c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
8d89cc9+dirty 3.19 MiB 4.53 MiB 1.35 MiB

Previous results on branch: alwx/improvement/sample-apps

Startup times

Revision Plain With Sentry Diff
771e482+dirty 1230.27 ms 1233.17 ms 2.90 ms
58c31b1+dirty 1256.13 ms 1254.61 ms -1.51 ms
2fff661+dirty 1219.98 ms 1226.14 ms 6.16 ms
ab7f938+dirty 1230.98 ms 1229.57 ms -1.40 ms
afe6a03+dirty 1227.51 ms 1228.43 ms 0.92 ms
66f1324+dirty 1231.80 ms 1233.14 ms 1.35 ms

App size

Revision Plain With Sentry Diff
771e482+dirty 3.19 MiB 4.38 MiB 1.19 MiB
58c31b1+dirty 3.19 MiB 4.53 MiB 1.34 MiB
2fff661+dirty 3.19 MiB 4.53 MiB 1.34 MiB
ab7f938+dirty 3.19 MiB 4.53 MiB 1.34 MiB
afe6a03+dirty 3.19 MiB 4.38 MiB 1.19 MiB
66f1324+dirty 3.19 MiB 4.38 MiB 1.19 MiB

@alwx alwx force-pushed the alwx/improvement/sample-apps branch from 86c75f1 to 86a520f Compare August 11, 2025 15:43
@alwx alwx changed the title WIP: Update sample apps to React Native 0.80 feat(sampleApps): Update sample apps to React Native 0.80, update other dependencies, improve code quality Aug 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 418.02 ms 413.41 ms -4.61 ms
Size 17.75 MiB 19.68 MiB 1.94 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
bc9680d 375.15 ms 401.12 ms 25.97 ms
a0b15d6 423.06 ms 437.77 ms 14.71 ms
c08359e 421.87 ms 445.37 ms 23.50 ms
eb07ba3 470.04 ms 473.35 ms 3.31 ms
af9331b 449.77 ms 479.20 ms 29.43 ms
1853710 555.47 ms 556.59 ms 1.12 ms
000da7a 454.46 ms 445.00 ms -9.46 ms
6479fd5+dirty 412.95 ms 434.02 ms 21.07 ms
ba75c7c 367.72 ms 369.16 ms 1.44 ms
c4e097a 338.06 ms 439.36 ms 101.30 ms

App size

Revision Plain With Sentry Diff
bc9680d 17.75 MiB 20.15 MiB 2.41 MiB
a0b15d6 17.75 MiB 20.15 MiB 2.41 MiB
c08359e 17.75 MiB 20.15 MiB 2.41 MiB
eb07ba3 17.75 MiB 20.15 MiB 2.41 MiB
af9331b 17.75 MiB 19.68 MiB 1.94 MiB
1853710 17.75 MiB 19.68 MiB 1.94 MiB
000da7a 17.75 MiB 19.68 MiB 1.94 MiB
6479fd5+dirty 17.75 MiB 19.68 MiB 1.94 MiB
ba75c7c 17.75 MiB 20.15 MiB 2.41 MiB
c4e097a 17.75 MiB 19.68 MiB 1.94 MiB

Previous results on branch: alwx/improvement/sample-apps

Startup times

Revision Plain With Sentry Diff
771e482 417.06 ms 427.72 ms 10.66 ms
58c31b1 406.58 ms 420.84 ms 14.25 ms
ab7f938 408.31 ms 428.40 ms 20.09 ms
afe6a03 438.14 ms 423.04 ms -15.10 ms
66f1324 416.52 ms 419.94 ms 3.42 ms
2fff661+dirty 434.51 ms 436.90 ms 2.39 ms

App size

Revision Plain With Sentry Diff
771e482 17.75 MiB 20.15 MiB 2.41 MiB
58c31b1 17.75 MiB 19.68 MiB 1.94 MiB
ab7f938 17.75 MiB 19.68 MiB 1.94 MiB
afe6a03 17.75 MiB 20.15 MiB 2.41 MiB
66f1324 17.75 MiB 20.15 MiB 2.41 MiB
2fff661+dirty 17.75 MiB 19.68 MiB 1.94 MiB

@alwx alwx force-pushed the alwx/improvement/sample-apps branch from 5db30fb to b1d66e9 Compare August 12, 2025 09:21
@alwx alwx marked this pull request as ready for review August 12, 2025 09:28
CHANGELOG.md Outdated
## Unreleased

- Update the sample app to React Native 0.80, update other dependencies, improve code quality of the sample app ([#5057](https://github.com/getsentry/sentry-react-native/pull/5057))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually omit internal changes like sample update.

@lucas-zimerman
Copy link
Collaborator

Q: Have you checked if the sample app is building on iOS?

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @alwx 🙇
Overall the changes LGTM! Awesome work tackling all these changes.

Q: Have you checked if the sample app is building on iOS?

I didn't manage to build locally either. I think this might be related to a RNReanimated issue also causing the Sample app build failure on CI.

@alwx
Copy link
Contributor Author

alwx commented Aug 13, 2025

@antonis @lucas-zimerman yes, I figured there is a problem with iOS build that but haven't yet managed to investigate because of TTID/TTFD work I'm doing in parallel. Will investigate and update this PR today.

@alwx alwx force-pushed the alwx/improvement/sample-apps branch 2 times, most recently from 080d1ea to 8d4bda7 Compare August 14, 2025 09:54
@alwx alwx requested review from antonis and lucas-zimerman August 14, 2025 13:00
@alwx alwx force-pushed the alwx/improvement/sample-apps branch 3 times, most recently from 579a75b to 930141a Compare August 29, 2025 12:47
@lucas-zimerman
Copy link
Collaborator

@alwx would you be able to resolve the conflicts if this PR isn't blocked by anything else?

@alwx
Copy link
Contributor Author

alwx commented Sep 15, 2025

@lucas-zimerman just got back from my PTO — this PR is going to be updated today.

@alwx alwx force-pushed the alwx/improvement/sample-apps branch from 930141a to 5ee7320 Compare September 16, 2025 07:32
NSDataAsset *data = [[NSDataAsset alloc] initWithName:@"ExampleBinaryData"];
if (data == nil) {
reject(@"SampleSentryReactNative", @"Failed to load exmaple binary data asset.", nil);
reject(@"SampleSentryReactNative", @"Failed to load example binary data asset.", nil);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! I would rather have these kinds of nits on a separated PR to not pollute the main PR, but we can leave this here.

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thank you for the PR!

@alwx alwx force-pushed the alwx/improvement/sample-apps branch from b3aa714 to 40116fa Compare September 18, 2025 07:24
@alwx alwx force-pushed the alwx/improvement/sample-apps branch from 40116fa to f5cac1b Compare September 18, 2025 07:26
@alwx alwx merged commit 6fee48d into main Sep 18, 2025
137 of 141 checks passed
@alwx alwx deleted the alwx/improvement/sample-apps branch September 18, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump sample apps to RN 0.80.0

4 participants