-
-
Notifications
You must be signed in to change notification settings - Fork 354
chore(deps): update Cocoa SDK to v8.53.2 #4986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3e2775e to
a995573
Compare
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 38a1af2 | 404.02 ms | 419.89 ms | 15.86 ms |
| a3aad2b | 453.57 ms | 463.62 ms | 10.05 ms |
| 1f1c420 | 403.32 ms | 411.98 ms | 8.66 ms |
| 6e8a851 | 425.59 ms | 433.51 ms | 7.92 ms |
| a8a0930 | 397.23 ms | 383.78 ms | -13.45 ms |
| 26286ef | 371.31 ms | 355.34 ms | -15.97 ms |
| 69721ae | 424.85 ms | 415.28 ms | -9.57 ms |
| df5da5d | 425.55 ms | 432.96 ms | 7.41 ms |
| 52d9c3f | 481.48 ms | 468.53 ms | -12.95 ms |
| 4e2cbd2 | 427.50 ms | 462.78 ms | 35.28 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 38a1af2 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| a3aad2b | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 1f1c420 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 6e8a851 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| a8a0930 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 26286ef | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 69721ae | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| df5da5d | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 52d9c3f | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 4e2cbd2 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f139dae | 415.36 ms | 400.73 ms | -14.63 ms |
| ba483fc | 407.51 ms | 398.52 ms | -8.99 ms |
| 6c67a16 | 442.07 ms | 454.91 ms | 12.84 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f139dae | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| ba483fc | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 6c67a16 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7d3c3cb+dirty | 395.20 ms | 413.24 ms | 18.04 ms |
| bd87539+dirty | 388.51 ms | 370.56 ms | -17.95 ms |
| 0e42017+dirty | 387.33 ms | 399.30 ms | 11.97 ms |
| ec2a485+dirty | 397.67 ms | 390.91 ms | -6.76 ms |
| 9e3030a+dirty | 390.15 ms | 381.82 ms | -8.33 ms |
| c352c30+dirty | 396.83 ms | 378.11 ms | -18.72 ms |
| 38a1af2+dirty | 421.38 ms | 431.35 ms | 9.97 ms |
| 940bd65+dirty | 408.45 ms | 419.75 ms | 11.30 ms |
| e12044e+dirty | 404.20 ms | 398.15 ms | -6.06 ms |
| bdb324a+dirty | 401.10 ms | 401.16 ms | 0.06 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7d3c3cb+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| bd87539+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 0e42017+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| ec2a485+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 9e3030a+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| c352c30+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 38a1af2+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 940bd65+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| e12044e+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| bdb324a+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6c67a16+dirty | 408.86 ms | 440.96 ms | 32.10 ms |
| f139dae+dirty | 383.66 ms | 389.28 ms | 5.62 ms |
| ba483fc+dirty | 432.91 ms | 454.14 ms | 21.23 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6c67a16+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| f139dae+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| ba483fc+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tackling the build issues in #4988
e8185a6 to
26b416d
Compare
|
I marked the PR as blocked, lets unblock it when #4988 is merged |
26b416d to
a81285b
Compare
…a 8.53.2 bump (#4988) * chore: update scripts/update-cocoa.sh to 8.53.2 * fix(session-replay): fixes navigation breadcrumb filtering after Cocoa 8.53.2 bump * Remove duplicate changelog entry after merge --------- Co-authored-by: GitHub <[email protected]>
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f2c6fa5+dirty | 1230.27 ms | 1236.20 ms | 5.93 ms |
| ec2a485+dirty | 1219.72 ms | 1224.66 ms | 4.94 ms |
| a8a0930+dirty | 1215.90 ms | 1227.82 ms | 11.92 ms |
| e12044e+dirty | 1233.45 ms | 1233.66 ms | 0.21 ms |
| 531450c+dirty | 1226.67 ms | 1233.10 ms | 6.43 ms |
| 26286ef+dirty | 1213.45 ms | 1229.96 ms | 16.51 ms |
| ab18954+dirty | 1230.53 ms | 1227.26 ms | -3.27 ms |
| d18ddb1+dirty | 1209.74 ms | 1209.65 ms | -0.10 ms |
| 940bd65+dirty | 1216.88 ms | 1225.23 ms | 8.35 ms |
| ba41c2a+dirty | 1232.60 ms | 1231.16 ms | -1.44 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f2c6fa5+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| ec2a485+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| a8a0930+dirty | 2.63 MiB | 3.79 MiB | 1.15 MiB |
| e12044e+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| 531450c+dirty | 2.63 MiB | 3.80 MiB | 1.17 MiB |
| 26286ef+dirty | 2.63 MiB | 3.80 MiB | 1.17 MiB |
| ab18954+dirty | 2.63 MiB | 3.80 MiB | 1.17 MiB |
| d18ddb1+dirty | 2.63 MiB | 3.80 MiB | 1.17 MiB |
| 940bd65+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| ba41c2a+dirty | 2.63 MiB | 3.80 MiB | 1.17 MiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ba483fc+dirty | 1211.24 ms | 1220.49 ms | 9.24 ms |
| 6c67a16+dirty | 1218.27 ms | 1224.22 ms | 5.96 ms |
| f139dae+dirty | 1220.86 ms | 1233.21 ms | 12.35 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ba483fc+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| 6c67a16+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| f139dae+dirty | 2.63 MiB | 3.80 MiB | 1.17 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c352c30+dirty | 1229.65 ms | 1241.33 ms | 11.67 ms |
| df5da5d+dirty | 1226.82 ms | 1234.88 ms | 8.06 ms |
| b4d6bde+dirty | 1218.73 ms | 1223.26 ms | 4.53 ms |
| a8a0930+dirty | 1212.11 ms | 1229.45 ms | 17.34 ms |
| e12044e+dirty | 1234.49 ms | 1228.85 ms | -5.64 ms |
| 531450c+dirty | 1225.94 ms | 1229.65 ms | 3.71 ms |
| 26286ef+dirty | 1207.33 ms | 1202.27 ms | -5.06 ms |
| ab18954+dirty | 1225.65 ms | 1226.09 ms | 0.44 ms |
| d18ddb1+dirty | 1200.88 ms | 1214.57 ms | 13.69 ms |
| ba41c2a+dirty | 1218.92 ms | 1221.02 ms | 2.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c352c30+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| df5da5d+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| b4d6bde+dirty | 3.19 MiB | 4.34 MiB | 1.16 MiB |
| a8a0930+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| e12044e+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| 531450c+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
| 26286ef+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
| ab18954+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
| d18ddb1+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
| ba41c2a+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
Previous results on branch: deps/scripts/update-cocoa.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ba483fc+dirty | 1203.07 ms | 1213.62 ms | 10.55 ms |
| 6c67a16+dirty | 1220.52 ms | 1223.47 ms | 2.95 ms |
| f139dae+dirty | 1213.82 ms | 1215.87 ms | 2.05 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ba483fc+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| 6c67a16+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
| f139dae+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
lucas-zimerman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Bumps scripts/update-cocoa.sh from 8.53.1 to 8.53.2.
Auto-generated by a dependency updater.
Changelog
8.53.2
Fixes
bindClient:is called from a different thread (#5523)Improvements
APPLICATION_EXTENSION_API_ONLYrequirement (#5524)