Skip to content

Conversation

@krystofwoldrich
Copy link
Contributor

#skip-changelog

Fixes

ITMS-90725: SDK version issue - This app was built with the iOS 17.4 SDK. Starting April 24, 2025, all iOS and iPadOS apps must be built with the iOS 18 SDK or later, included in Xcode 16 or later, in order to be uploaded to App Store Connect or submitted for distribution.

@github-actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 462.52 ms 479.40 ms 16.88 ms
Size 17.75 MiB 20.12 MiB 2.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0db0c72 372.12 ms 386.00 ms 13.88 ms
e1ea4a8 506.82 ms 510.48 ms 3.66 ms
c830127 407.57 ms 409.50 ms 1.93 ms
d7401ac+dirty 375.20 ms 383.51 ms 8.31 ms
94fc925 446.39 ms 484.80 ms 38.41 ms
3261206 476.43 ms 465.96 ms -10.48 ms
db44eaf 437.65 ms 436.06 ms -1.59 ms
8de2810 430.47 ms 428.72 ms -1.75 ms
690220d 468.28 ms 480.06 ms 11.78 ms
d43a46b 454.22 ms 477.79 ms 23.57 ms

App size

Revision Plain With Sentry Diff
0db0c72 17.73 MiB 19.75 MiB 2.02 MiB
e1ea4a8 17.74 MiB 20.08 MiB 2.34 MiB
c830127 17.74 MiB 20.10 MiB 2.36 MiB
d7401ac+dirty 17.73 MiB 19.75 MiB 2.02 MiB
94fc925 17.75 MiB 20.11 MiB 2.37 MiB
3261206 17.75 MiB 20.11 MiB 2.37 MiB
db44eaf 17.74 MiB 20.08 MiB 2.35 MiB
8de2810 17.74 MiB 20.08 MiB 2.34 MiB
690220d 17.74 MiB 20.08 MiB 2.35 MiB
d43a46b 17.73 MiB 20.06 MiB 2.33 MiB

@github-actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 419.90 ms 430.36 ms 10.46 ms
Size 7.15 MiB 8.39 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6e8584e+dirty 383.37 ms 400.84 ms 17.47 ms
8c88ac7+dirty 402.72 ms 434.32 ms 31.60 ms
05b43ab+dirty 392.00 ms 386.12 ms -5.88 ms
d2c32bb+dirty 445.45 ms 497.85 ms 52.41 ms
9385d74+dirty 381.56 ms 416.02 ms 34.46 ms
d361d38+dirty 257.72 ms 318.76 ms 61.04 ms
c6f01ea+dirty 379.95 ms 439.35 ms 59.40 ms
e4d9fe0+dirty 368.38 ms 415.44 ms 47.05 ms
6707be9+dirty 431.52 ms 461.14 ms 29.62 ms
2534337+dirty 597.14 ms 665.04 ms 67.90 ms

App size

Revision Plain With Sentry Diff
6e8584e+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
8c88ac7+dirty 7.15 MiB 8.35 MiB 1.20 MiB
05b43ab+dirty 7.15 MiB 8.38 MiB 1.22 MiB
d2c32bb+dirty 7.15 MiB 8.35 MiB 1.20 MiB
9385d74+dirty 7.15 MiB 8.37 MiB 1.22 MiB
d361d38+dirty 7.15 MiB 8.08 MiB 959.34 KiB
c6f01ea+dirty 7.15 MiB 8.37 MiB 1.22 MiB
e4d9fe0+dirty 7.15 MiB 8.38 MiB 1.23 MiB
6707be9+dirty 7.15 MiB 8.38 MiB 1.23 MiB
2534337+dirty 7.15 MiB 8.11 MiB 988.68 KiB

@krystofwoldrich
Copy link
Contributor Author

After the change, I have not received the email with ITMS-90725.

@github-actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.59 ms 1226.29 ms 0.69 ms
Size 2.63 MiB 3.75 MiB 1.12 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f54118b+dirty 1232.98 ms 1235.73 ms 2.76 ms
d8e8c67+dirty 1222.57 ms 1226.22 ms 3.65 ms
d8668ce+dirty 1225.18 ms 1228.08 ms 2.90 ms
cdc3945+dirty 1202.43 ms 1223.65 ms 21.23 ms
ae7b03d+dirty 1221.19 ms 1224.69 ms 3.50 ms
4a6664f+dirty 1209.49 ms 1208.63 ms -0.86 ms
d053743+dirty 1213.69 ms 1218.88 ms 5.18 ms
e540498+dirty 1220.61 ms 1212.93 ms -7.68 ms
63ed251+dirty 1232.55 ms 1238.77 ms 6.22 ms
e73d82f+dirty 1207.52 ms 1216.73 ms 9.21 ms

App size

Revision Plain With Sentry Diff
f54118b+dirty 2.36 MiB 3.10 MiB 757.51 KiB
d8e8c67+dirty 2.36 MiB 3.12 MiB 779.40 KiB
d8668ce+dirty 2.36 MiB 3.08 MiB 737.08 KiB
cdc3945+dirty 2.63 MiB 3.75 MiB 1.12 MiB
ae7b03d+dirty 2.63 MiB 3.69 MiB 1.05 MiB
4a6664f+dirty 2.36 MiB 3.04 MiB 696.39 KiB
d053743+dirty 2.63 MiB 3.75 MiB 1.12 MiB
e540498+dirty 2.36 MiB 3.14 MiB 793.34 KiB
63ed251+dirty 2.36 MiB 3.10 MiB 752.55 KiB
e73d82f+dirty 2.36 MiB 3.08 MiB 734.23 KiB

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Thank you for upgrading this on CI Krystof 🙇

@github-actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.77 ms 1221.10 ms 5.34 ms
Size 3.19 MiB 4.32 MiB 1.13 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f54118b+dirty 1235.42 ms 1236.80 ms 1.38 ms
d8e8c67+dirty 1235.58 ms 1233.44 ms -2.15 ms
d8668ce+dirty 1249.70 ms 1242.31 ms -7.39 ms
cdc3945+dirty 1216.51 ms 1223.55 ms 7.04 ms
ae7b03d+dirty 1223.71 ms 1227.69 ms 3.98 ms
4a6664f+dirty 1218.77 ms 1221.07 ms 2.30 ms
d053743+dirty 1223.18 ms 1214.25 ms -8.93 ms
e540498+dirty 1254.92 ms 1247.21 ms -7.71 ms
63ed251+dirty 1223.27 ms 1222.94 ms -0.33 ms
e73d82f+dirty 1231.20 ms 1228.81 ms -2.40 ms

App size

Revision Plain With Sentry Diff
f54118b+dirty 2.92 MiB 3.67 MiB 770.05 KiB
d8e8c67+dirty 2.92 MiB 3.69 MiB 790.53 KiB
d8668ce+dirty 2.92 MiB 3.64 MiB 742.99 KiB
cdc3945+dirty 3.19 MiB 4.32 MiB 1.13 MiB
ae7b03d+dirty 3.19 MiB 4.25 MiB 1.06 MiB
4a6664f+dirty 2.92 MiB 3.60 MiB 702.09 KiB
d053743+dirty 3.19 MiB 4.32 MiB 1.13 MiB
e540498+dirty 2.92 MiB 3.69 MiB 794.14 KiB
63ed251+dirty 2.92 MiB 3.66 MiB 757.10 KiB
e73d82f+dirty 2.92 MiB 3.64 MiB 740.56 KiB

@krystofwoldrich krystofwoldrich merged commit 1d7ae00 into main Feb 26, 2025
73 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-fix-testflight-outdated-ios-sdk branch February 26, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants