Skip to content

Add update_current_span to SDK 3 #4679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 6, 2025

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Aug 6, 2025

Merging master into potel-base, done in a PR because there have been some changes needed to the span.name setter to make it work for potel.

@antonpirker antonpirker changed the base branch from master to potel-base August 6, 2025 14:06
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.99%. Comparing base (c27ac1f) to head (3ecdbba).
⚠️ Report is 6 commits behind head on potel-base.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/api.py 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           potel-base    #4679      +/-   ##
==============================================
+ Coverage       83.75%   84.99%   +1.23%     
==============================================
  Files             158      158              
  Lines           15517    15539      +22     
  Branches         2456     2461       +5     
==============================================
+ Hits            12997    13208     +211     
+ Misses           1765     1573     -192     
- Partials          755      758       +3     
Files with missing lines Coverage Δ
sentry_sdk/__init__.py 100.00% <ø> (ø)
sentry_sdk/consts.py 99.68% <100.00%> (+<0.01%) ⬆️
sentry_sdk/tracing.py 82.59% <100.00%> (+0.93%) ⬆️
sentry_sdk/api.py 94.54% <80.00%> (-1.46%) ⬇️

... and 12 files with indirect coverage changes

@antonpirker antonpirker marked this pull request as ready for review August 6, 2025 14:39
@antonpirker antonpirker requested a review from a team as a code owner August 6, 2025 14:39
@antonpirker antonpirker merged commit b27b201 into potel-base Aug 6, 2025
112 of 114 checks passed
@antonpirker antonpirker deleted the antonpirker/potel-update-current-span branch August 6, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant