Skip to content

feat(tracing): AI Agents templates for @trace decorator #4676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 83 commits into from
Aug 13, 2025
Merged

feat(tracing): AI Agents templates for @trace decorator #4676

merged 83 commits into from
Aug 13, 2025
+555 −13

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Aug 6, 2025 •
edited
Loading

Adding a template parameter to the @trace decorator to make it easier to manually create spans for insights modules. Currently there are three templates supported ai_agent, ai_tool, and ai_chat.

antonpirker added 30 commits July 30, 2025 14:27
@antonpirker
First version of helpers for better manual instrumentation
1162254
@antonpirker
minor improvements
4346db1
@antonpirker
A nicer implementation
bfc6626
@antonpirker
style
f193ecb
@antonpirker
fixing setting of name
8488a53
@antonpirker
Some linting
5621f15
@antonpirker
Replaced original trace decorator with new_decorator
43ff0c6
@antonpirker
Cleanup
6a5c88e
@antonpirker
fix start child
74941d4
@antonpirker
If no span, do nothing
6d36b28
@antonpirker
change less code
09d5646
@antonpirker
comment
3020f92
@antonpirker
its description internally
acd5401
@antonpirker
move _set_span_attribuets into span
695dd06
@antonpirker
typing
5068c5b
@antonpirker
.
98c8d42
@antonpirker
Add enum for template
35e7809
@antonpirker
Make some consts public
a538d2a
@antonpirker
Also make op part of public api
241d5cf
@antonpirker
sort
33f79b8
@antonpirker
Allow setting a key to None
dbbf3b4
@antonpirker
Merge branch 'master' into antonpirker/manual-instrumentation
cfec8c0
@antonpirker
typing
c234dd4
@antonpirker
Guess some attributes from input/response
cf5382f
@antonpirker
fix tool description
fdcdfdf
@antonpirker
Added more token names
9917808
@antonpirker
better span naming
7c1076b
@antonpirker
Tool input and output
a6eed59
@antonpirker
Check PII settings before adding tool input/output
2011ab4
@antonpirker
Better usage extraction
668a421
@antonpirker antonpirker changed the title AI Agents templates for @trace decorator feat(agents): AI Agents templates for @trace decorator Aug 6, 2025
Base automatically changed from antonpirker/manual-instrumentation to master August 7, 2025 08:20
@antonpirker antonpirker changed the title feat(agents): AI Agents templates for @trace decorator feat(tracing): AI Agents templates for @trace decorator Aug 11, 2025
sentrivana
sentrivana reviewed Aug 11, 2025
View reviewed changes
cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

sentrivana
sentrivana reviewed Aug 13, 2025
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are looking much better, also thanks for the dedup.

There's still some places where it'd be good to dedup, see comments

cursor[bot]

This comment was marked as outdated.

Sign in to view

@antonpirker antonpirker enabled auto-merge (squash) August 13, 2025 10:54
@antonpirker antonpirker merged commit 1804955 into master Aug 13, 2025
138 of 139 checks passed
@antonpirker antonpirker deleted the manual-instrumentation2 branch August 13, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonpirker @sentrivana