Skip to content

Bump dotnet signal tests to .net 10 #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaMoelans merged 3 commits into from
Dec 1, 2025
Merged

Bump dotnet signal tests to .net 10 #1457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
760b918
Bump dotnet signal tests to .net 10
jamescrosswell Nov 26, 2025
024e464
add dotnet install for ARM64 runner
JoshuaMoelans Nov 27, 2025
894d5ae
Apply suggestion from @JoshuaMoelans
JoshuaMoelans Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/docker/alpine/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ RUN apk add \
tree \
wget

RUN curl -sSL --retry 5 https://dot.net/v1/dotnet-install.sh | bash -eo pipefail /dev/stdin --channel 8.0 --install-dir /usr/share/dotnet
RUN curl -sSL --retry 5 https://dot.net/v1/dotnet-install.sh | bash -eo pipefail /dev/stdin --channel 10.0 --install-dir /usr/share/dotnet
RUN ln -s /usr/share/dotnet/dotnet /usr/local/bin/dotnet

# https://github.com/actions/runner-images/blob/main/images/ubuntu/scripts/build/install-python.sh
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,15 @@ jobs:
run: |
apk update
apk add curl-dev libunwind-dev libunwind-static xz-dev
# install manually until available by default (also for future .NET updates)
- name: Install .NET 10 SDK for ARM64 runners
Comment on lines +263 to +264
Copy link

@sentry sentry bot Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: dotnet signal tests will fail on non-ARM64 Linux runners due to missing .NET 10 SDK, as the installation step is ARM64-specific.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The dotnet signal tests (test_dotnet_signals_inproc, test_aot_signals_inproc) are configured to run on non-ARM64 Linux runners (e.g., ubuntu-24.04, ubuntu-22.04). These tests require the .NET 10 SDK to execute commands like dotnet run and dotnet publish. However, the new CI step responsible for installing .NET 10 is conditionally limited to ARM64 runners. Since .NET 10 is not yet pre-installed on GitHub Actions' non-ARM64 Linux images, these tests will fail with errors such as "dotnet: command not found" or "The .NET SDK cannot be located", breaking the CI pipeline on affected configurations.

💡 Suggested Fix

Modify the .NET 10 SDK installation step's condition to include non-ARM64 Linux runners where the dotnet signal tests are expected to run, or ensure these tests are skipped on configurations without the SDK.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/ci.yml#L263-L264

Potential issue: The `dotnet` signal tests (`test_dotnet_signals_inproc`,
`test_aot_signals_inproc`) are configured to run on non-ARM64 Linux runners (e.g.,
ubuntu-24.04, ubuntu-22.04). These tests require the .NET 10 SDK to execute commands
like `dotnet run` and `dotnet publish`. However, the new CI step responsible for
installing .NET 10 is conditionally limited to `ARM64` runners. Since .NET 10 is not yet
pre-installed on GitHub Actions' non-ARM64 Linux images, these tests will fail with
errors such as "dotnet: command not found" or "The .NET SDK cannot be located", breaking
the CI pipeline on affected configurations.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 4395437

Copy link
Member

@JoshuaMoelans JoshuaMoelans Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is passing on the other platforms, since .NET is already installed. Hence we only need this step specifically for the ARM64-Linux runner.

if: ${{ runner.os == 'Linux' && runner.arch == 'ARM64' && !matrix.container }}
run: |
wget https://dot.net/v1/dotnet-install.sh -O dotnet-install.sh
chmod +x dotnet-install.sh
./dotnet-install.sh --channel 10.0 --install-dir $HOME/.dotnet
echo "$HOME/.dotnet" >> $GITHUB_PATH
echo "DOTNET_ROOT=$HOME/.dotnet" >> $GITHUB_ENV

# https://github.com/actions/runner-images/issues/9491
- name: Decrease vm.mmap_rnd_bit to prevent ASLR ASAN issues
Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/dotnet_signal/test_dotnet.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
Expand Down
Loading