Skip to content

fix: Fix CheckIn constructor argument order #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2023
Merged

fix: Fix CheckIn constructor argument order #680

merged 1 commit into from
Apr 18, 2023

Conversation

@cleptric
Copy link
Member

@cleptric cleptric commented Apr 18, 2023

The signature is

    public function __construct(
        string $monitorSlug,
        CheckInStatus $status,
        string $id = null,
        ?string $release = null,
        ?string $environment = null,
        $duration = null
    ) {

@cleptric cleptric self-assigned this Apr 18, 2023
@cleptric cleptric requested a review from stayallive April 18, 2023 08:52
stayallive
stayallive approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@cleptric cleptric merged commit f95e516 into master Apr 18, 2023
@cleptric cleptric deleted the fix-checkin-args branch April 18, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stayallive stayallive stayallive approved these changes

Assignees

@cleptric cleptric

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cleptric @stayallive