Fix missing breadcrumbs for jobs throwing an exception #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we hold references for these scopes/breadcrumbs somewhere? If so, we could purge them after X accumulated. |
|
To prevent issues with scopes / breadcrumbs pilling up we pop the scope (if we had pushed one) before starting a new job / scope. For the mostly happy paths in the tests this works correctly. This seems like an improvement but feel free to poke holes in my assumptions! |
cleptric
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #632.
There is a downside with this "fix" (hence still a draft).
We might be leaking memory here since we never cleanup any breadcrumbs from failed queue jobs. When a queue workers is running this might be an issue where these breadcrumbs will never be visible but are kept in memory. So when a queue worker churns through say 500 jobs that threw exceptions it has 1500 breadcrumbs (3 per scope) and 500 scopes (unless we limit the amount of scopes already!?).
So not a 100% sure this is the way.
A fix for this can be where we pop the scope if we need to before we run a job, however that breaks this test where the middle breadcrumb from this test is being lost which is not ideal either.