Change debug trace limit in makeAnEducatedGuessIfTheExceptionMaybeWasHandled method

[kayw-geek]

The current method to limiting the call stack is not suitable for all users of the Sentry SDK, for example, some users have added additional logic based on Sentry, which can cause the call stack to exceed the limit and result in an unexpected unhandled flag.

[cleptric]

I think the current default is very reasonable.
Can you provide us with some concrete example of where this would not work?

[kayw-geek]

I think the current default is very reasonable. Can you provide us with some concrete example of where this would not work?

OK, I have some custom extra logic in our own private library laravel-sentry, so I didn't get to report helper until the 11th call stack.

[kayw-geek]

I don't think this is an individual case.
and I don't think limiting the number of call stack calls has much significance in terms of performance, because when we find this report helper in a loop, it will return and stop the loop.

[stayallive]

I don't think this is an individual case.

You are the first to report this, so unless we have a lot more people chip in, it might be. In a "normal" Laravel application we expect the stack to be around 5-6 long before hitting the report helper frame so you are definitly doing a lot of indirection.

Regardless, we limit the amout of stack frames to prevent doing work that is not needed, Sentry threads a fine line between reporting accurate errors and being performant enought to not cause more problems than it's reporting.

That said, I'd be willing to bump it to 20 because I can see 10 might be a little on the thin side, but making it unbounded is not a good idea since not all errors go through report and the loop is not "free" especially with your example where you have 80+ stackframes :)

20 seems to also cover your case and then some, sounds good?

[kayw-geek]

Sure, I will change the limit count to 20.

[stayallive]

Thanks!

[kayw-geek]

Hi @cleptric, Is there any plan to release a new tag recently?

[cleptric]

@kayw-geek We'll get something out this week.

[kayw-geek]

@kayw-geek We'll get something out this week.

Thanks!

[cleptric]

@kayw-geek released in https://github.com/getsentry/sentry-laravel/releases/tag/3.1.3

[kayw-geek]

Thanks, I see it!