feat(tanstackstart-react): Trace server routes #18546
Open
+78
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| return target.apply(thisArg, args); | ||
| }, | ||
| ); | ||
| }, |
There was a problem hiding this comment.
Bug: Nested http.server spans duplicate root spans
Wrapping every serverEntry.fetch call in startSpan with op = 'http.server' creates a child http.server span when an incoming-request transaction is already active (e.g., from Node HTTP auto-instrumentation). This can produce duplicate http.server spans in a single trace and misleading timings/attributes because the inner span ends when the handler returns, not when the response finishes.
nicohrubec
commented
Dec 17, 2025
| ); | ||
| } else { | ||
| // API route or other server request | ||
| op = 'http.server'; |
Member
Author
There was a problem hiding this comment.
Not sure if this is the correct op or if we should use something tanstack specific here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tracing for tss server routes (and other http server requests), by extending the implementation in the existing
wrapFetchWithSentrywrapper.Screenshot from my sample app for a server route request:
Tests added:
Closes #18284