-
-
Notifications
You must be signed in to change notification settings - Fork 226
Update all samples to use the latest TFMs #4782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Note that I can't test this (my Apple Developer account has expired)... hoping Stefan can help :-)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4782 +/- ##
==========================================
- Coverage 73.90% 73.87% -0.03%
==========================================
Files 485 485
Lines 17682 17682
Branches 3494 3494
==========================================
- Hits 13067 13063 -4
- Misses 3758 3760 +2
- Partials 857 859 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The error we're seeing now in CI is: This may be related to: @Flash0ver potentially we revert to net9 for the WASM sample until this is a bit more stable in .net 10? |
samples/Sentry.Samples.AspNetCore.Blazor.Wasm/Sentry.Samples.AspNetCore.Blazor.Wasm.csproj
Show resolved
Hide resolved
|
Inexplicably, this commit seems to have broken the unit tests on Possibly the commit is entirely unrelated but, if so, I can't see any other differences between the environments between the successful and unsuccessful runs. Commit 6722643 confirms it's nothing to do with the change, but we do finally get some clues from the logs:
|
This reverts commit 6722643. # Conflicts: # samples/Sentry.Samples.Ios/AppDelegate.cs
| @@ -1,10 +1,6 @@ | |||
| <Router AppAssembly="@typeof(Program).Assembly"> | |||
| <Router AppAssembly="@typeof(App).Assembly" NotFoundPage="typeof(Pages.NotFound)"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing @ prefix in Razor attribute expression
The NotFoundPage attribute value is missing the @ prefix for the C# expression. The value typeof(Pages.NotFound) is being treated as a string literal instead of a type expression. Compare with AppAssembly="@typeof(App).Assembly" and DefaultLayout="@typeof(MainLayout)" on the same component which correctly use the @ prefix. This will cause the Router to not properly recognize the NotFound page type.
Co-authored-by: Stefan Pölz <[email protected]>
Resolves #4584
#skip-changelog