-
-
Notifications
You must be signed in to change notification settings - Fork 226
meta: add Sentry.Extensions.AI to repository files #4773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| nuget:Sentry.Extensions.AI: | ||
| nuget:Sentry.Extensions.Logging: | ||
| nuget:Sentry.Google.Cloud.Functions: | ||
| nuget:Sentry.Hangfire: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Do we still need this file?
Sentry.Extensions.AI is already on NuGet.org.
And Sentry.Hangfire has been for almost 2 years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it gets used when our release workflow runs, to publish new versions to nuget (otherwise nuget would be stuck on the current version that has been uploaded):
https://github.com/getsentry/craft?tab=readme-ov-file#craft-publish-publishing-the-release
We change this file so infrequently that I'm not sure though (I don't recall ever changing this file myself).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4773 +/- ##
==========================================
- Coverage 73.91% 73.88% -0.03%
==========================================
Files 485 485
Lines 17682 17682
Branches 3494 3494
==========================================
- Hits 13070 13065 -5
- Misses 3755 3759 +4
- Partials 857 858 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sentry review |
jamescrosswell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adding the brand new Sentry.Extensions.AI to these repository files:
.craft.yml.github/ISSUE_TEMPLATE/bug_report.ymlREADME.md