-
-
Notifications
You must be signed in to change notification settings - Fork 226
chore(deps): update Java SDK to v8.26.0 #4728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
72648cc to
9334b32
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4728 +/- ##
==========================================
+ Coverage 73.66% 73.68% +0.01%
==========================================
Files 476 476
Lines 17449 17449
Branches 3455 3455
==========================================
+ Hits 12854 12857 +3
+ Misses 3747 3744 -3
Partials 848 848 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jamescrosswell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking until we've merged version6
9334b32 to
19dd815
Compare
19dd815 to
5abcd76
Compare
5abcd76 to
5653b5d
Compare
Avoids the following errors:
Sentry.Bindings.Android net10.0-android36.0 failed with 3 error(s) (1.2s)
src/Sentry.Bindings.Android/obj/Release/net10.0-android36.0/generated/src/IO.Sentry.Util.Network.INetworkBody.cs(18,68): error CS0050: Inconsistent accessibility: return type 'INetworkBody' is less accessible than method 'NetworkBody.FromJsonArray(IList<Object>)'
src/Sentry.Bindings.Android/obj/Release/net10.0-android36.0/generated/src/IO.Sentry.Util.Network.INetworkBody.cs(36,68): error CS0050: Inconsistent accessibility: return type 'INetworkBody' is less accessible than method 'NetworkBody.FromJsonObject(IDictionary<string, Object>)'
src/Sentry.Bindings.Android/obj/Release/net10.0-android36.0/generated/src/IO.Sentry.Util.Network.INetworkBody.cs(54,68): error CS0050: Inconsistent accessibility: return type 'INetworkBody' is less accessible than method 'NetworkBody.FromString(string)'
|
I pushed a proposal to remove NetworkBody to avoid the following errors: |
Thanks JP... I guess it's either that or change the visibility on it, but if we're not using it for anything, we may as well remove it. |
Bumps scripts/update-java.ps1 from 8.24.0 to 8.26.0.
Auto-generated by a dependency updater.
Changelog
8.26.0
Features
Sentry.addFeatureFlag("my-feature-flag", true);) writes to scopes and the current span (if there is one)IScope,IScopes,ISpanandITransactiondirectlyFixes
DefaultReplayBreadcrumbConverterif replay is available (#4888)Improvements
timber.taglog attribute (#4845)Dependencies
8.25.0
Fixes
Improvements
sampled == null) won't be collecting any performance data anymore (CPU, RAM, slow/frozen frames).Dependencies