fix: Multiple sentry.proguard-uuid being set in Android manifest

[alexsohn1126]

Fixes #4597

• io.sentry.proguard-uuid error during _ManifestMerger step when building MAUI app #4597

Problem

The setup described in #4597 is the following:

• Project A (MAUI app)
  • references project B and C
• Project B (Android Library)
  • Targets net9.0-android
  • references project C
• Project C
  • a simple class library

Then the build will fail on _ManifestMerger step, due to the duplicated Android manifest metadata sentry.proguard-uuid.

This was caused by sentry.proguard-uuid being set up every time an Android project is built. So in the reproducible example above, sentry.proguard-uuid would be set in Project A and B.

Solution

I added a check to ensure sentry.proguard-uuid is set only when the property AndroidApplication is set to true, which is set to True for MAUI apps, so when MSBuild gets to project B, it doesn't generate another UUID and tries to inject it to the Android manifest.

See also:

• AndroidApplication property - Microsoft Learn

Notes (feel free to ignore)

I have tried putting the UpdateAndroidMetadata target into a separate src/Sentry/build/Sentry.targets file (to prevent the target from running transitively), but could not get it to work.

If future problems arise where the proguard-uuid is being set multiple times, we may need to consider that as a more permanent solution

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.53%. Comparing base (ad849d4) to head (489fa67).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4647      +/-   ##
==========================================
+ Coverage   73.45%   73.53%   +0.07%     
==========================================
  Files         482      483       +1     
  Lines       17678    17692      +14     
  Branches     3493     3492       -1     
==========================================
+ Hits        12986    13009      +23     
+ Misses       3801     3795       -6     
+ Partials      891      888       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jamescrosswell]

Added one small recommendation but otherwise LGTM. 🚀

Thanks @alexsohn1126!

[bruno-garcia]

@sentry review

[bruno-garcia]

after that pretty bad review comment from Cursor, I'm curious what Sentry will do here

[bruno-garcia]

I guess nothing because it has already been merged