fix: de-duplicate Java.Lang.RuntimeException on Android #4509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpnurmi
changed the title
Flash0ver
reviewed
Sep 10, 2025
| options.EnableScopeSync = true; | ||
| options.ScopeObserver = new AndroidScopeObserver(options); | ||
| // Don't capture Java Runtime exceptions in the managed SDK, since we already capture them in the native SDK | ||
| options.AddExceptionFilterForType<Java.Lang.RuntimeException>(); |
Member
There was a problem hiding this comment.
question: test
Is there a (somewhat) straightforward way to (unit) test the suppression of the double capture?
Perhaps via
#if ANDROID
SentrySdk.CauseCrash(CrashType.Java);
#endifor would this need to be an integration test?
Collaborator
Author
There was a problem hiding this comment.
I couldn't find any suitable place for testing this. Native SDKs are not initialized in unit tests, and integration tests only run on desktop platforms. Once we have the infrastructure for e2e tests, though, then we can hopefully start testing these things:
jamescrosswell
approved these changes
Sep 10, 2025
Collaborator
jamescrosswell
left a comment
jamescrosswell
left a comment
There was a problem hiding this comment.
LGTM - thank you!
This was referenced Sep 11, 2025
This was referenced Sep 15, 2025
This was referenced Sep 22, 2025
This was referenced Oct 1, 2025
This was referenced Oct 13, 2025
This was referenced Oct 20, 2025
This was referenced Nov 3, 2025
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java runtime exceptions are caught in two layers:
For example, the result of exactly one
CrashType.JavaThreadand oneCrashType.JavaBackgroundThread:Fixes: #4237