feat(logs): add Buffering and Batching

benchmarks/Sentry.Benchmarks/BenchmarkDotNet.Artifacts/results/Sentry.Benchmarks.StructuredLogBatchProcessorBenchmarks-report-github.md

@@ -0,0 +1,18 @@
+```
+
+BenchmarkDotNet v0.13.12, macOS 15.5 (24F74) [Darwin 24.5.0]
+Apple M3 Pro, 1 CPU, 12 logical and 12 physical cores
+.NET SDK 9.0.301
+  [Host]     : .NET 8.0.14 (8.0.1425.11118), Arm64 RyuJIT AdvSIMD
+  DefaultJob : .NET 8.0.14 (8.0.1425.11118), Arm64 RyuJIT AdvSIMD
+
+
+```
+| Method          | BatchCount | OperationsPerInvoke | Mean        | Error    | StdDev   | Gen0   | Allocated |
+|---------------- |----------- |-------------------- |------------:|---------:|---------:|-------:|----------:|
+| **EnqueueAndFlush** | **10**         | **100**                 |  **1,774.5 ns** |  **7.57 ns** |  **6.71 ns** | **0.6104** |      **5 KB** |
+| **EnqueueAndFlush** | **10**         | **200**                 |  **3,468.5 ns** | **11.16 ns** | **10.44 ns** | **1.2207** |     **10 KB** |
+| **EnqueueAndFlush** | **10**         | **1000**                | **17,259.7 ns** | **51.92 ns** | **46.02 ns** | **6.1035** |     **50 KB** |
+| **EnqueueAndFlush** | **100**        | **100**                 |    **857.5 ns** |  **4.21 ns** |  **3.73 ns** | **0.1469** |    **1.2 KB** |
+| **EnqueueAndFlush** | **100**        | **200**                 |  **1,681.4 ns** |  **1.74 ns** |  **1.63 ns** | **0.2937** |   **2.41 KB** |
+| **EnqueueAndFlush** | **100**        | **1000**                |  **8,302.2 ns** | **12.00 ns** | **10.64 ns** | **1.4648** |  **12.03 KB** |

benchmarks/Sentry.Benchmarks/StructuredLogBatchProcessorBenchmarks.cs

@@ -0,0 +1,68 @@
+using BenchmarkDotNet.Attributes;
+using NSubstitute;
+using Sentry.Extensibility;
+using Sentry.Internal;
+
+namespace Sentry.Benchmarks;
+
+public class StructuredLogBatchProcessorBenchmarks
+{
+    private Hub _hub;
+    private StructuredLogBatchProcessor _batchProcessor;
+    private SentryLog _log;
+
+    [Params(10, 100)]
+    public int BatchCount { get; set; }
+
+    [Params(100, 200, 1_000)]
+    public int OperationsPerInvoke { get; set; }
+
+    [GlobalSetup]
+    public void Setup()
+    {
+        SentryOptions options = new()
+        {
+            Dsn = DsnSamples.ValidDsn,
+            Experimental =
+            {
+                EnableLogs = true,
+            },
+        };
+
+        var batchInterval = Timeout.InfiniteTimeSpan;
+
+        var clientReportRecorder = Substitute.For<IClientReportRecorder>();
+        clientReportRecorder
+            .When(static recorder => recorder.RecordDiscardedEvent(Arg.Any<DiscardReason>(), Arg.Any<DataCategory>(), Arg.Any<int>()))
+            .Throw<UnreachableException>();
+
+        var diagnosticLogger = Substitute.For<IDiagnosticLogger>();
+        diagnosticLogger
+            .When(static logger => logger.IsEnabled(Arg.Any<SentryLevel>()))
+            .Throw<UnreachableException>();
+        diagnosticLogger
+            .When(static logger => logger.Log(Arg.Any<SentryLevel>(), Arg.Any<string>(), Arg.Any<Exception>(), Arg.Any<object[]>()))
+            .Throw<UnreachableException>();
+
+        _hub = new Hub(options, DisabledHub.Instance);
+        _batchProcessor = new StructuredLogBatchProcessor(_hub, BatchCount, batchInterval, clientReportRecorder, diagnosticLogger);
+        _log = new SentryLog(DateTimeOffset.Now, SentryId.Empty, SentryLogLevel.Trace, "message");
+    }
+
+    [Benchmark]
+    public void EnqueueAndFlush()
+    {
+        for (var i = 0; i < OperationsPerInvoke; i++)
+        {
+            _batchProcessor.Enqueue(_log);
+        }
+        _batchProcessor.Flush();
+    }
+
+    [GlobalCleanup]
+    public void Cleanup()
+    {
+        _batchProcessor.Dispose();
+        _hub.Dispose();
+    }
+}

src/Sentry/Internal/DefaultSentryStructuredLogger.cs

@@ -1,6 +1,5 @@
 using Sentry.Extensibility;
 using Sentry.Infrastructure;
-using Sentry.Protocol.Envelopes;
 
 namespace Sentry.Internal;
 
@@ -10,15 +9,21 @@ internal sealed class DefaultSentryStructuredLogger : SentryStructuredLogger
     private readonly SentryOptions _options;
     private readonly ISystemClock _clock;
 
-    internal DefaultSentryStructuredLogger(IHub hub, SentryOptions options, ISystemClock clock)
+    private readonly StructuredLogBatchProcessor _batchProcessor;
+
+    internal DefaultSentryStructuredLogger(IHub hub, SentryOptions options, ISystemClock clock, int batchCount, TimeSpan batchInterval)
     {
+        Debug.Assert(hub.IsEnabled);
         Debug.Assert(options is { Experimental.EnableLogs: true });
 
         _hub = hub;
         _options = options;
         _clock = clock;
+
+        _batchProcessor = new StructuredLogBatchProcessor(hub, batchCount, batchInterval, _options.ClientReportRecorder, _options.DiagnosticLogger);
     }
 
+    /// <inheritdoc />
     private protected override void CaptureLog(SentryLogLevel level, string template, object[]? parameters, Action<SentryLog>? configureLog)
     {
         var timestamp = _clock.GetUtcNow();
@@ -71,9 +76,24 @@ private protected override void CaptureLog(SentryLogLevel level, string template
 
         if (configuredLog is not null)
         {
-            //TODO: enqueue in Batch-Processor / Background-Worker
-            // see https://github.com/getsentry/sentry-dotnet/issues/4132
-            _ = _hub.CaptureEnvelope(Envelope.FromLog(configuredLog));
+            _batchProcessor.Enqueue(configuredLog);
         }
     }
+
+    /// <inheritdoc />
+    protected internal override void Flush()
+    {
+        _batchProcessor.Flush();
+    }
+
+    /// <inheritdoc />
+    protected override void Dispose(bool disposing)
+    {
+        if (disposing)
+        {
+            _batchProcessor.Dispose();
+        }
+
+        base.Dispose(disposing);
+    }
 }

src/Sentry/Internal/DisabledSentryStructuredLogger.cs

@@ -8,8 +8,15 @@ internal DisabledSentryStructuredLogger()
     {
     }
 
+    /// <inheritdoc />
     private protected override void CaptureLog(SentryLogLevel level, string template, object[]? parameters, Action<SentryLog>? configureLog)
     {
         // disabled
     }
+
+    /// <inheritdoc />
+    protected internal override void Flush()
+    {
+        // disabled
+    }
 }

src/Sentry/Internal/DiscardReason.cs

@@ -11,6 +11,7 @@ namespace Sentry.Internal;
     public static DiscardReason QueueOverflow = new("queue_overflow");
     public static DiscardReason RateLimitBackoff = new("ratelimit_backoff");
     public static DiscardReason SampleRate = new("sample_rate");
+    public static DiscardReason Backpressure = new("backpressure");
 
     private readonly string _value;
 

src/Sentry/Internal/Hub.cs

@@ -819,6 +819,9 @@ public void Dispose()
         _memoryMonitor?.Dispose();
 #endif
 
+        Logger.Flush();
+        Logger.Dispose();
+
         try
         {
             CurrentClient.FlushAsync(_options.ShutdownTimeout).ConfigureAwait(false).GetAwaiter().GetResult();