-
-
Notifications
You must be signed in to change notification settings - Fork 226
fix: MSBuild target produces incorrect release name #4015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tested manually on MacOS and the new commands run by the transitive build still work fine: Thanks @huynhsontung ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4015 +/- ##
==========================================
+ Coverage 75.73% 76.77% +1.04%
==========================================
Files 357 397 +40
Lines 13466 14418 +952
Branches 2671 2896 +225
==========================================
+ Hits 10198 11069 +871
- Misses 2593 2635 +42
- Partials 675 714 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks again @huynhsontung - apologies it took so long to merge this. It'll be included in the next point release. |
Fixes #4005
Remove the single quotes in the Exec tasks within the MSBuild target to prevent them from being included in the release name. This is necessary because Exec tasks invoke the Command Prompt, which does not strip quotes from parameters.