Skip to content

Conversation

@huynhsontung
Copy link
Contributor

Fixes #4005

Remove the single quotes in the Exec tasks within the MSBuild target to prevent them from being included in the release name. This is necessary because Exec tasks invoke the Command Prompt, which does not strip quotes from parameters.

@jamescrosswell
Copy link
Collaborator

Tested manually on MacOS and the new commands run by the transitive build still work fine:

Creating Sentry Release: [email protected]+75536de656a77296b0ed5bfab7dab8265b078df2
"/Users/jamescrosswell/code/sentry-dotnet/tools/sentry-cli/2.42.2/sentry-cli-Darwin-arm64" releases new [email protected]+75536de656a77296b0ed5bfab7dab8265b078df2  --org sentry-sdks --project sentry-dotnet
Created release [email protected]+75536de656a77296b0ed5bfab7dab8265b078df2
Created release [email protected]+75536de656a77296b0ed5bfab7dab8265b078df2
Setting Sentry commits
Setting Sentry commits
"/Users/jamescrosswell/code/sentry-dotnet/tools/sentry-cli/2.42.2/sentry-cli-Darwin-arm64" releases set-commits --local [email protected]+75536de656a77296b0ed5bfab7dab8265b078df2  --org sentry-sdks --project sentry-dotnet
"/Users/jamescrosswell/code/sentry-dotnet/tools/sentry-cli/2.42.2/sentry-cli-Darwin-arm64" releases set-commits --local [email protected]+75536de656a77296b0ed5bfab7dab8265b078df2  --org sentry-sdks --project sentry-dotnet

Thanks @huynhsontung !

@codecov
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.77%. Comparing base (495e742) to head (52ad28e).
Report is 516 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4015      +/-   ##
==========================================
+ Coverage   75.73%   76.77%   +1.04%     
==========================================
  Files         357      397      +40     
  Lines       13466    14418     +952     
  Branches     2671     2896     +225     
==========================================
+ Hits        10198    11069     +871     
- Misses       2593     2635      +42     
- Partials      675      714      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamescrosswell jamescrosswell merged commit 992547e into getsentry:main Mar 26, 2025
22 checks passed
@jamescrosswell
Copy link
Collaborator

Thanks again @huynhsontung - apologies it took so long to merge this. It'll be included in the next point release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a release through Sentry in MSBuild results in incorrect release name

3 participants