Skip to content

Ignore null value on CocoaScopeObserver.SetTag #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 6 commits into from
Feb 11, 2025
Merged

Ignore null value on CocoaScopeObserver.SetTag #3948

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
edb4d74
Ignore null values when setting tag on CocoaScopeObserver
Cheesebaron Feb 9, 2025
6f94b7e
Test null value on tag in iOS sample
Cheesebaron Feb 9, 2025
d98cfc4
Revert sample change
Cheesebaron Feb 10, 2025
68bb047
Add general scope test
Cheesebaron Feb 10, 2025
85f4c12
Update src/Sentry/Platforms/Cocoa/CocoaScopeObserver.cs
Cheesebaron Feb 11, 2025
2da2322
Update changelog
Cheesebaron Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Sentry/Platforms/Cocoa/CocoaScopeObserver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ public void SetExtra(string key, object? value)

public void SetTag(string key, string value)
{
if (value is null)
{
_options.LogDebug("Tag with key '{0}' was null.", key);
return;
}

try
{
SentryCocoaSdk.ConfigureScope(scope => scope.SetTagValue(value, key));
Expand Down
18 changes: 18 additions & 0 deletions test/Sentry.Tests/ScopeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,24 @@ public void Filtered_tags_are_not_set()

scope.Tags.Should().OnlyContain(pair => pair.Key == "AzFunctions" && pair.Value == "rule");
}

[Fact]
public void SetTag_NullValue_DoesNotThrowArgumentNullException()
{
var scope = new Scope();

ArgumentNullException exception = null;
try
{
scope.SetTag("IAmNull", null);
}
catch (ArgumentNullException e)
{
exception = e;
}

Assert.Null(exception);
}
}

public static class ScopeTestExtensions
Expand Down
Loading