Skip to content

Conversation

@jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Dec 4, 2024

#skip-changelog

Summary

The only changes in this PR are bumping the version of Verify.Xunit from version 22.11.4 to version 26.6.0 and removing all the [UsesVerify] attributes that are no longer required or supported by the new version of Verify.

Important Note

This change results in a missing a debug image in test/Sentry.NLog.Tests/IntegrationTests.Simple.Mono4_0.verified.txt.

Oddly the debug image is only missing in CI. When I run this test on my Mac locally, it passes.

For the time being, we'll skip this test on Mono in CI. This issue has been created instead:

Here's the diff on CI when running this test on macos-15 (arm64) and ubuntu (x64)

              SentryExceptions: [
                {
                  Type: System.Exception,
                  Value: Exception message,
                  Stacktrace: {
                    Frames: [
                      {
                        FileName: ,
                        Function: Task IntegrationTests.Simple(),
                        Module: null,
                        LineNumber: null,
                        ColumnNumber: null,
                        AbsolutePath: null,
                        ContextLine: null,
                        InApp: false,
                        Package: Sentry.NLog.Tests, Version=SCRUBBED, Culture=SCRUBBED, PublicKeyToken=SCRUBBED,
                        Platform: null,
                        ImageAddress: null,
                        SymbolAddress: null,
                        InstructionAddress: 2,
-                       AddressMode: rel:0,
-                       FunctionId: 1
+                       AddressMode: null,
+                       FunctionId: null
                      }
                    ]
                  },
                  Mechanism: {
                    Type: generic,
                    Handled: true,
                    Synthetic: false,
                    IsExceptionGroup: false
-                 }
                  }
-             ],
-             DebugImages: [
-               {
-                 Type: pe_dotnet,
-                 ImageAddress: null,
-                 ImageSize: null,
-                 DebugId: ________-____-____-____-____________-________,
-                 DebugChecksum: ______:________________________________________________________________,
-                 DebugFile: .../Sentry.NLog.Tests.pdb,
-                 CodeId: ______________,
-                 CodeFile: .../Sentry.NLog.Tests.dll
                }
              ],

Base automatically changed from drop-eol-xunit to main December 4, 2024 20:15
@jamescrosswell jamescrosswell marked this pull request as ready for review December 5, 2024 04:27
@jamescrosswell jamescrosswell requested a review from vaind December 5, 2024 04:28
@jamescrosswell jamescrosswell merged commit fcc9628 into main Dec 5, 2024
23 checks passed
@jamescrosswell jamescrosswell deleted the drop-eol-verify branch December 5, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants