Skip to content

Conversation

@vaind
Copy link
Contributor

@vaind vaind commented Nov 22, 2024

The default (which was the previous behaviour when the udpater was created) creates new branch & PR for every release.

The "update" strategy updates a single PR per dependency.

The default (which was the previous behaviour when the udpater was created) creates new branch & PR for every release.

The "update" strategy updates a single PR per dependency.
@bruno-garcia bruno-garcia merged commit 2ec949f into main Nov 24, 2024
20 checks passed
@bruno-garcia bruno-garcia deleted the vaind-patch-1 branch November 24, 2024 00:12
@jamescrosswell
Copy link
Collaborator

Not sure I get this. Why does this matter? So what problem does changing to update strategy solve?

@vaind
Copy link
Contributor Author

vaind commented Nov 25, 2024

Not sure I get this. Why does this matter? So what problem does changing to update strategy solve?

less maintenance when you need don't want to merge a dependency yet but need to wait for another release. Also applies when you just don't care about the update because it doesn't change anything for the consuming SDK. You can leave the PR open and it will get updated the next time there's a release on the dependency, instead of creating multiple PRs, one for each version.

@jamescrosswell
Copy link
Collaborator

You can leave the PR open and it will get updated the next time there's a release on the dependency, instead of creating multiple PRs, one for each version.

Ahhh, I see. Cool, thanks @vaind !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants