Report correct SDK name on native (NDK) Android crashes

[bruno-garcia]

Crashes coming form sentry.native under the Android SDK should be reported as:

sentry.native.android.dotnet

Currently, it's reported as sentry.native.android, which is the same as standalone Android apps.

On the Unity SDK, we override it at compile time, and here we don't recompile the SDK so not sure if it can be easily done:

https://github.com/getsentry/sentry-unity/blob/e4d3d4d13ed0ab3f4e2a05534bfb8592c92e319d/Directory.Build.targets#L190

[jamescrosswell]

Yeah it looks like in the Java repo it's baked in at build time:
getsentry/sentry-java@66140be

I think we'd need some other mechanism to be made available to set this for the .NET SDK.

[vaind]

Runtime setting:

https://github.com/getsentry/sentry-java/blob/b5b093e5f805d0d02c7be344403804e7a7605398/sentry-android-core/src/main/java/io/sentry/android/core/SentryAndroidOptions.java#L464C1-L473C4

[jamescrosswell]

Currently, it's reported as sentry.native.android, which is the same as standalone Android apps.

Hm, something is off here. We set this in the .NET SDK already:

sentry-dotnet/src/Sentry/Platforms/Android/SentrySdk.cs

Line 170 in b0a1996

o.NativeSdkName = "sentry.native.dotnet";

So whilst we could change that to sentry.native.android.dotnet, if it's coming through as sentry.native.android at the moment then that mechanism isn't working as it should at the moment.

[bruno-garcia]

Currently, it's reported as sentry.native.android, which is the same as standalone Android apps.

Hm, something is off here. We set this in the .NET SDK already:

sentry-dotnet/src/Sentry/Platforms/Android/SentrySdk.cs

Line 170 in b0a1996

         o.NativeSdkName = "sentry.native.dotnet"; 

So whilst we could change that to sentry.native.android.dotnet, if it's coming through as sentry.native.android at the moment then that mechanism isn't working as it should at the moment.

This is definitely wrong. If we're passing this down to the Java layer, it should be sentry.java.android.dotnet (appending .dotnet to the original name).
If we're passing this to the NDK layer (sentry-native). Appending .dotnet would result in: sentry.native.android.dotnet

Mistake was added here:
3e8edb7#diff-382226eacb7ee000748a4a5ea92c800b032a7225426a84d1e945e5aff7f20011R166

[bitsandfoxes]

Fixed by #3682

[jamescrosswell]

@bitsandfoxes I'm not certain #3682 fixes this. In the issue description:

Currently, it's reported as sentry.native.android

The PR changes o.NativeSdkName from "sentry.native.dotnet" to "sentry.native.android.dotnet". So that particular code was never responsible for reporting it as sentry.native.android.

[bitsandfoxes]

Either the PR description is off or I'm missing something here:

• Event prior to fix: sdk name for native on android #3682 coming from our Samples.Android
  
• Event after fix: sdk name for native on android #3682 coming from our Samples.Android
  

[bitsandfoxes]

Overwriting via the option seems to work just fine.

I think we can close this one.