Fix reference to span in processOrderBatch function #14741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
please also review other instances |
adinauer
approved these changes
Aug 27, 2025
Bundle ReportChanges will increase total bundle size by 1.78kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
markushi
commented
Aug 27, 2025
| void processOrderBatch() { | ||
| ISpan span = Sentry.getSpan(); | ||
| if (span == null) { | ||
| span = Sentry.startTransaction("processOrderBatch()", "task"); |
Member
Author
There was a problem hiding this comment.
I've removed this, as the sample code never finishes the transaction
adinauer
approved these changes
Aug 28, 2025
codyde
added a commit
that referenced
this pull request
Aug 28, 2025
…om/getsentry/sentry-docs into feat/nextjs-centralized-flow-clean * 'feat/nextjs-centralized-flow-clean' of https://github.com/getsentry/sentry-docs: Fix reference to span in processOrderBatch function (#14741) chore(java): Add docs on how to use tracePropagationTargets (#14752) docs(replay): Bring replay nav item to all apple platforms (#14710) User Feedback Basics Page (#14670) Update AM3 and legacy billing for logs GA, DO NOT MERGE BEFORE LOGS GA (#14589) Add LLMSteering component for hidden documentation instructions (#14744) New data retention policy page (#14661) Adding error prediction to Prevent AI docs (#14641)
codyde
added a commit
that referenced
this pull request
Aug 29, 2025
* 'master' of https://github.com/getsentry/sentry-docs: feat(seer): Seer webhook docs (#14702) feat: Update logs spec to mention message template constraint (#14759) Unreal Engine: Update sampling docs (#14740) Unreal Engine: Update info about reading certain options from env vars (#14714) feat(Apple): Add `enableUnhandledCPPExceptionsV2` to experimental features (#14731) feat(kmp): Add Sentry Cocoa compatibility version info (#14737) Fix reference to span in processOrderBatch function (#14741) chore(java): Add docs on how to use tracePropagationTargets (#14752)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
There's no
it, should bespan.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES