ref(v9): Remove v9 todos #12740
Merged
ref(v9): Remove v9 todos #12740
+5
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
andreiborza
force-pushed
the
ab/remove-todo-v9
branch
from
dff5f80 to
2ca2f01
Compare
Collaborator
|
I've already had a PR for this for Electron but was waiting for the next major to be released before it gets merged: |
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
Member
Author
|
@timfish ah, didn't see. Also missed that the major wasn't released yet. Will remove these from my pr :) |
Lms24
reviewed
Feb 17, 2025
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Had a concern RE removing the autoSessionTracking note
|
|
||
| {/* We don't use platform links here because we always have to link to node and browser here and doing a conditional just for that feels overkill. */} | ||
|
|
||
| Starting with SDK version 8.43.0 and up, the `autoSessionTracking` option has been deprecated. You can use the [BrowserSession integration](/platforms/javascript/configuration/integrations/browsersession/) in browser environments and the [Http integration](/platforms/javascript/guides/node/configuration/integrations/http/) (via the `trackIncomingRequestsAsSessions` option) in Node.js runtime. |
Member
There was a problem hiding this comment.
IIUC, autoSessionTracking is no longer available but we still mention it above. I'm not 100% familiar with the replacement but my guess is we should document the httpIntegration option mentioned in the deprecation notice?
Member
Author
There was a problem hiding this comment.
Good catch, I updated the docs according to the migration guide.
andreiborza
force-pushed
the
ab/remove-todo-v9
branch
from
11c45d3 to
5051bae
Compare
timfish
approved these changes
Feb 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: getsentry/sentry-javascript#14325