Skip to content

fix: wasm compat #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2025
Merged

fix: wasm compat #2580

merged 3 commits into from
Jan 20, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jan 16, 2025

💡 Motivation and Context

Fixes wasm compat for drift, current pub dev scoring CI fails because the file not wasm compatible

https://github.com/getsentry/sentry-dart/runs/35661207095

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.98%. Comparing base (7659cbe) to head (f6a66fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2580      +/-   ##
==========================================
+ Coverage   88.87%   88.98%   +0.10%     
==========================================
  Files         122      262     +140     
  Lines        4333     8966    +4633     
==========================================
+ Hits         3851     7978    +4127     
- Misses        482      988     +506     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 438.02 ms 525.82 ms 87.80 ms
Size 6.46 MiB 7.48 MiB 1.03 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a49594a 282.27 ms 344.84 ms 62.57 ms
09eab47 455.30 ms 478.46 ms 23.16 ms
752e1cb 472.85 ms 511.60 ms 38.76 ms
19a9adb 448.00 ms 543.82 ms 95.82 ms
48e79fd 354.22 ms 391.46 ms 37.24 ms
464b4d0 320.71 ms 380.02 ms 59.31 ms
74e1fdd 398.61 ms 418.43 ms 19.82 ms
1c6eb5b 350.69 ms 393.86 ms 43.17 ms
af2d175 279.08 ms 312.37 ms 33.29 ms
1596141 300.92 ms 368.94 ms 68.02 ms

App size

Revision Plain With Sentry Diff
a49594a 5.94 MiB 6.95 MiB 1.01 MiB
09eab47 6.49 MiB 7.56 MiB 1.07 MiB
752e1cb 6.49 MiB 7.57 MiB 1.08 MiB
19a9adb 6.46 MiB 7.48 MiB 1.01 MiB
48e79fd 5.94 MiB 6.95 MiB 1.01 MiB
464b4d0 6.06 MiB 7.03 MiB 990.27 KiB
74e1fdd 6.33 MiB 7.27 MiB 954.12 KiB
1c6eb5b 5.94 MiB 6.92 MiB 1001.53 KiB
af2d175 5.94 MiB 6.92 MiB 1001.83 KiB
1596141 6.16 MiB 7.14 MiB 1003.98 KiB

Previous results on branch: fix/wasm-compat

Startup times

Revision Plain With Sentry Diff
17962f0 472.67 ms 518.26 ms 45.59 ms

App size

Revision Plain With Sentry Diff
17962f0 6.46 MiB 7.48 MiB 1.02 MiB

Copy link
Contributor

github-actions bot commented Jan 16, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1248.55 ms 1264.81 ms 16.26 ms
Size 8.42 MiB 9.89 MiB 1.47 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a758ebd 1256.90 ms 1277.67 ms 20.77 ms
3637a22 1290.39 ms 1318.42 ms 28.03 ms
68677de 1245.20 ms 1273.51 ms 28.31 ms
824df58 1235.72 ms 1259.02 ms 23.30 ms
daa1b33 1224.41 ms 1244.59 ms 20.18 ms
f735167 1259.67 ms 1270.61 ms 10.94 ms
5f2f77b 1231.76 ms 1248.43 ms 16.67 ms
2331d89 1260.86 ms 1281.24 ms 20.39 ms
a2ec542 1258.33 ms 1267.20 ms 8.88 ms
be08ed1 1247.12 ms 1272.19 ms 25.07 ms

App size

Revision Plain With Sentry Diff
a758ebd 8.38 MiB 9.75 MiB 1.37 MiB
3637a22 8.09 MiB 9.07 MiB 1001.02 KiB
68677de 8.10 MiB 9.16 MiB 1.07 MiB
824df58 8.33 MiB 9.64 MiB 1.31 MiB
daa1b33 8.28 MiB 9.34 MiB 1.05 MiB
f735167 8.42 MiB 9.86 MiB 1.44 MiB
5f2f77b 8.33 MiB 9.64 MiB 1.31 MiB
2331d89 8.16 MiB 9.17 MiB 1.01 MiB
a2ec542 8.10 MiB 9.14 MiB 1.05 MiB
be08ed1 8.32 MiB 9.38 MiB 1.06 MiB

Previous results on branch: fix/wasm-compat

Startup times

Revision Plain With Sentry Diff
17962f0 1252.46 ms 1263.92 ms 11.46 ms

App size

Revision Plain With Sentry Diff
17962f0 8.42 MiB 9.89 MiB 1.47 MiB

@buenaflor buenaflor marked this pull request as ready for review January 20, 2025 11:37
@buenaflor buenaflor merged commit e503e3c into main Jan 20, 2025
150 checks passed
@buenaflor buenaflor deleted the fix/wasm-compat branch January 20, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants