-
-
Notifications
You must be signed in to change notification settings - Fork 269
fix: android replay touch events #2515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2515 +/- ##
==========================================
+ Coverage 87.01% 91.59% +4.57%
==========================================
Files 265 88 -177
Lines 9426 3081 -6345
==========================================
- Hits 8202 2822 -5380
+ Misses 1224 259 -965 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3d305b9 | 403.55 ms | 469.76 ms | 66.20 ms |
af2d175 | 279.08 ms | 312.37 ms | 33.29 ms |
7f97e6c | 447.29 ms | 480.76 ms | 33.46 ms |
68677de | 364.41 ms | 415.61 ms | 51.20 ms |
f056db1 | 426.04 ms | 475.76 ms | 49.72 ms |
824df58 | 436.68 ms | 548.80 ms | 112.12 ms |
acbd5d3 | 367.53 ms | 428.76 ms | 61.23 ms |
5baa201 | 389.26 ms | 462.83 ms | 73.57 ms |
870f5eb | 329.45 ms | 369.29 ms | 39.84 ms |
e3d9076 | 388.08 ms | 488.51 ms | 100.43 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3d305b9 | 6.35 MiB | 7.35 MiB | 1021.16 KiB |
af2d175 | 5.94 MiB | 6.92 MiB | 1001.83 KiB |
7f97e6c | 6.49 MiB | 7.56 MiB | 1.07 MiB |
68677de | 6.06 MiB | 7.10 MiB | 1.04 MiB |
f056db1 | 6.52 MiB | 7.61 MiB | 1.09 MiB |
824df58 | 6.35 MiB | 7.35 MiB | 1021.71 KiB |
acbd5d3 | 6.35 MiB | 7.35 MiB | 1017.84 KiB |
5baa201 | 6.35 MiB | 7.33 MiB | 1005.56 KiB |
870f5eb | 5.94 MiB | 6.92 MiB | 1005.77 KiB |
e3d9076 | 6.34 MiB | 7.28 MiB | 967.79 KiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
72dfc83 | 1262.50 ms | 1289.75 ms | 27.25 ms |
d7758e8 | 1271.69 ms | 1288.08 ms | 16.39 ms |
afa6e2a | 1251.04 ms | 1266.65 ms | 15.61 ms |
42f6e7e | 1232.52 ms | 1247.86 ms | 15.34 ms |
0118295 | 1211.31 ms | 1227.02 ms | 15.71 ms |
464b4d0 | 1249.02 ms | 1261.22 ms | 12.20 ms |
7ec9238 | 1259.69 ms | 1281.59 ms | 21.90 ms |
50bdfad | 1253.14 ms | 1274.54 ms | 21.40 ms |
9d43f71 | 1225.06 ms | 1227.06 ms | 2.00 ms |
5e7abc5 | 1258.38 ms | 1284.56 ms | 26.19 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
72dfc83 | 8.15 MiB | 9.12 MiB | 987.30 KiB |
d7758e8 | 8.15 MiB | 9.12 MiB | 989.76 KiB |
afa6e2a | 8.28 MiB | 9.33 MiB | 1.05 MiB |
42f6e7e | 8.28 MiB | 9.33 MiB | 1.05 MiB |
0118295 | 8.32 MiB | 9.38 MiB | 1.05 MiB |
464b4d0 | 8.10 MiB | 9.16 MiB | 1.07 MiB |
7ec9238 | 8.34 MiB | 9.65 MiB | 1.31 MiB |
50bdfad | 8.32 MiB | 9.43 MiB | 1.10 MiB |
9d43f71 | 8.29 MiB | 9.39 MiB | 1.10 MiB |
5e7abc5 | 8.33 MiB | 9.39 MiB | 1.06 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps