Skip to content

Include sentry frames to enable crash detection #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 13, 2024
Merged

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented May 13, 2024

📜 Description

Adds sentry frames to stacktrace, this won't affect grouping

See https://sentry-sdks.sentry.io/issues/4722238716/events/d70d73150b2a401e9b56755f968cc1de/?project=5428562&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=next-event&statsPeriod=1h&stream_index=0

💡 Motivation and Context

part of getsentry/sentry#66762

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@buenaflor buenaflor requested a review from philipphofmann May 13, 2024 10:52
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (0f067d3) to head (abe56e0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2050   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files          54       54           
  Lines        1788     1788           
=======================================
  Hits         1704     1704           
  Misses         84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 13, 2024

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1247.54 ms 1278.35 ms 30.81 ms
Size 8.32 MiB 9.52 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
521cfbf 1258.94 ms 1275.18 ms 16.25 ms
43760f9 1216.07 ms 1238.51 ms 22.44 ms
be8cafe 1239.94 ms 1266.20 ms 26.27 ms
2331d89 1260.86 ms 1281.24 ms 20.39 ms
ef6466d 1209.88 ms 1225.81 ms 15.93 ms
746a779 1227.06 ms 1243.53 ms 16.47 ms
f1314d5 1246.46 ms 1270.92 ms 24.46 ms
d0312c9 1205.55 ms 1224.45 ms 18.90 ms
c3e6c82 1256.93 ms 1276.17 ms 19.24 ms
fe4aa56 1248.82 ms 1261.35 ms 12.53 ms

App size

Revision Plain With Sentry Diff
521cfbf 8.16 MiB 9.17 MiB 1.01 MiB
43760f9 8.29 MiB 9.36 MiB 1.07 MiB
be8cafe 8.33 MiB 9.40 MiB 1.07 MiB
2331d89 8.16 MiB 9.17 MiB 1.01 MiB
ef6466d 8.33 MiB 9.40 MiB 1.07 MiB
746a779 8.28 MiB 9.33 MiB 1.05 MiB
f1314d5 8.10 MiB 9.08 MiB 1004.30 KiB
d0312c9 8.32 MiB 9.39 MiB 1.06 MiB
c3e6c82 8.32 MiB 9.38 MiB 1.06 MiB
fe4aa56 8.10 MiB 9.08 MiB 1004.36 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 368.98 ms 435.92 ms 66.94 ms
Size 6.33 MiB 7.30 MiB 992.36 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8cb6557 321.20 ms 370.46 ms 49.26 ms
8ced2dc 295.58 ms 336.49 ms 40.91 ms
ca7f531 395.69 ms 497.82 ms 102.12 ms
636cb61 366.59 ms 448.14 ms 81.55 ms
3e4b523 294.88 ms 347.30 ms 52.42 ms
f275487 369.08 ms 432.44 ms 63.36 ms
f4cc744 349.53 ms 394.68 ms 45.15 ms
ef31c7f 311.39 ms 359.33 ms 47.94 ms
8e4eeb3 365.78 ms 435.58 ms 69.80 ms
e0f6628 380.21 ms 450.39 ms 70.17 ms

App size

Revision Plain With Sentry Diff
8cb6557 6.06 MiB 7.03 MiB 997.01 KiB
8ced2dc 6.06 MiB 7.03 MiB 990.29 KiB
ca7f531 6.33 MiB 7.26 MiB 949.75 KiB
636cb61 6.27 MiB 7.20 MiB 959.08 KiB
3e4b523 6.26 MiB 7.20 MiB 958.78 KiB
f275487 6.33 MiB 7.26 MiB 947.03 KiB
f4cc744 5.94 MiB 6.95 MiB 1.01 MiB
ef31c7f 6.06 MiB 7.09 MiB 1.03 MiB
8e4eeb3 6.33 MiB 7.27 MiB 954.12 KiB
e0f6628 6.33 MiB 7.29 MiB 987.23 KiB

@buenaflor buenaflor merged commit 20eb554 into main May 13, 2024
@buenaflor buenaflor deleted the enh/keep-sentry-frames branch May 13, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants