Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Nov 4, 2025

Remove SentryIntegrationProtocol from public API

#skip-changelog

Closes #6661

@codecov
Copy link

codecov bot commented Nov 4, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3968 1 3967 26
View the top 1 failed test(s) by shortest run time
iOS_SwiftUI_UITests.FeedbackUITests::testWidgetDisplayInSwiftUIApp
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/FeedbackUITests.swift:14 - Failed to get matching snapshots: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin force-pushed the removeSentryIntegrationProtocolAPI branch 2 times, most recently from 2eb180f to 942adcd Compare November 4, 2025 13:38
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1192.81 ms 1216.50 ms 23.69 ms
Size 23.75 KiB 1023.81 KiB 1000.06 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3279d4e 1215.76 ms 1256.45 ms 40.69 ms
37183fe 1212.33 ms 1238.92 ms 26.59 ms
80a5166 1224.49 ms 1251.29 ms 26.80 ms
0b5fd21 1237.52 ms 1251.36 ms 13.84 ms
8745cc0 1228.13 ms 1250.48 ms 22.35 ms
ebc72be 1221.24 ms 1249.66 ms 28.42 ms
0b6776b 1230.18 ms 1262.06 ms 31.88 ms
6e99155 1223.96 ms 1249.25 ms 25.29 ms
e8f9a1d 1229.02 ms 1264.17 ms 35.15 ms
535ebd9 1194.59 ms 1219.84 ms 25.26 ms

App size

Revision Plain With Sentry Diff
3279d4e 23.75 KiB 938.32 KiB 914.57 KiB
37183fe 23.75 KiB 913.63 KiB 889.87 KiB
80a5166 23.75 KiB 904.53 KiB 880.78 KiB
0b5fd21 23.75 KiB 912.78 KiB 889.03 KiB
8745cc0 23.74 KiB 971.81 KiB 948.07 KiB
ebc72be 23.75 KiB 908.22 KiB 884.47 KiB
0b6776b 23.75 KiB 968.23 KiB 944.49 KiB
6e99155 23.75 KiB 963.18 KiB 939.43 KiB
e8f9a1d 23.75 KiB 969.78 KiB 946.04 KiB
535ebd9 23.75 KiB 1008.67 KiB 984.92 KiB

@noahsmartin noahsmartin force-pushed the removeSentryIntegrationProtocolAPI branch from 942adcd to 61788e7 Compare November 4, 2025 17:49
@noahsmartin noahsmartin merged commit 5b90eb2 into main Nov 4, 2025
193 of 198 checks passed
@noahsmartin noahsmartin deleted the removeSentryIntegrationProtocolAPI branch November 4, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Remove SentryIntegrationProtocol from public API

3 participants