-
-
Notifications
You must be signed in to change notification settings - Fork 372
Update iOS versions for V9 #6316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
itaybre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update Sentry.podspec, SentryPrivate, SentrySwiftUI.podspec?
6355d20 to
0b1c653
Compare
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 073562b | 1232.63 ms | 1259.88 ms | 27.24 ms |
| ccf1278 | 1226.84 ms | 1248.51 ms | 21.67 ms |
| 2b02431 | 1229.63 ms | 1248.98 ms | 19.35 ms |
| 8d944ac | 1236.92 ms | 1254.91 ms | 18.00 ms |
| 48e5c8a | 1223.02 ms | 1242.38 ms | 19.35 ms |
| d66f082 | 1227.08 ms | 1247.04 ms | 19.96 ms |
| 04ff3ec | 1220.71 ms | 1253.86 ms | 33.15 ms |
| 0dd7283 | 1230.47 ms | 1255.94 ms | 25.47 ms |
| 1fecbb8 | 1242.78 ms | 1265.40 ms | 22.62 ms |
| bc0a04c | 1226.83 ms | 1255.04 ms | 28.21 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 073562b | 23.75 KiB | 927.06 KiB | 903.31 KiB |
| ccf1278 | 23.75 KiB | 877.15 KiB | 853.40 KiB |
| 2b02431 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| 8d944ac | 23.75 KiB | 919.69 KiB | 895.94 KiB |
| 48e5c8a | 23.75 KiB | 913.63 KiB | 889.88 KiB |
| d66f082 | 23.75 KiB | 928.85 KiB | 905.10 KiB |
| 04ff3ec | 23.75 KiB | 880.26 KiB | 856.52 KiB |
| 0dd7283 | 23.74 KiB | 997.28 KiB | 973.53 KiB |
| 1fecbb8 | 23.75 KiB | 969.28 KiB | 945.53 KiB |
| bc0a04c | 23.75 KiB | 933.32 KiB | 909.57 KiB |
0b1c653 to
dfc7afd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6316 +/- ##
========================================
Coverage ? 86.840%
========================================
Files ? 438
Lines ? 37343
Branches ? 17438
========================================
Hits ? 32429
Misses ? 4869
Partials ? 45 Continue to review full report in Codecov by Sentry.
|
97cc7c7 to
9094bc5
Compare
9094bc5 to
302948f
Compare
302948f to
ea12675
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when CI is green, thanks a lot @noahsmartin
2d1a6cc to
c83c67e
Compare
f09f8bf to
c5e96ae
Compare
c5e96ae to
9cd4d6b
Compare
Updating this to match the xcconfig file V9 settings
#skip-changelog
Closes #6317