Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 1, 2025

Updating this to match the xcconfig file V9 settings

#skip-changelog

Closes #6317

Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.91 ms 1257.74 ms 35.83 ms
Size 23.75 KiB 990.16 KiB 966.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
073562b 1232.63 ms 1259.88 ms 27.24 ms
ccf1278 1226.84 ms 1248.51 ms 21.67 ms
2b02431 1229.63 ms 1248.98 ms 19.35 ms
8d944ac 1236.92 ms 1254.91 ms 18.00 ms
48e5c8a 1223.02 ms 1242.38 ms 19.35 ms
d66f082 1227.08 ms 1247.04 ms 19.96 ms
04ff3ec 1220.71 ms 1253.86 ms 33.15 ms
0dd7283 1230.47 ms 1255.94 ms 25.47 ms
1fecbb8 1242.78 ms 1265.40 ms 22.62 ms
bc0a04c 1226.83 ms 1255.04 ms 28.21 ms

App size

Revision Plain With Sentry Diff
073562b 23.75 KiB 927.06 KiB 903.31 KiB
ccf1278 23.75 KiB 877.15 KiB 853.40 KiB
2b02431 23.75 KiB 850.73 KiB 826.98 KiB
8d944ac 23.75 KiB 919.69 KiB 895.94 KiB
48e5c8a 23.75 KiB 913.63 KiB 889.88 KiB
d66f082 23.75 KiB 928.85 KiB 905.10 KiB
04ff3ec 23.75 KiB 880.26 KiB 856.52 KiB
0dd7283 23.74 KiB 997.28 KiB 973.53 KiB
1fecbb8 23.75 KiB 969.28 KiB 945.53 KiB
bc0a04c 23.75 KiB 933.32 KiB 909.57 KiB

cursor[bot]

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@854ca12). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #6316   +/-   ##
========================================
  Coverage        ?   86.840%           
========================================
  Files           ?       438           
  Lines           ?     37343           
  Branches        ?     17438           
========================================
  Hits            ?     32429           
  Misses          ?      4869           
  Partials        ?        45           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 854ca12...9cd4d6b. Read the comment docs.

@noahsmartin noahsmartin changed the title Update ios version in package file Update iOS versions for V9 Oct 2, 2025
@noahsmartin noahsmartin force-pushed the packageVersion branch 4 times, most recently from 97cc7c7 to 9094bc5 Compare October 2, 2025 15:30
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when CI is green, thanks a lot @noahsmartin

@noahsmartin noahsmartin force-pushed the packageVersion branch 3 times, most recently from 2d1a6cc to c83c67e Compare October 3, 2025 15:49
cursor[bot]

This comment was marked as outdated.

@noahsmartin noahsmartin force-pushed the packageVersion branch 4 times, most recently from f09f8bf to c5e96ae Compare October 3, 2025 16:49
@noahsmartin noahsmartin merged commit 09471ff into main Oct 3, 2025
207 of 211 checks passed
@noahsmartin noahsmartin deleted the packageVersion branch October 3, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ios version in package file

5 participants