Skip to content

ref: Use slice instead of vec for assemble artifact request #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

ref: Use slice instead of vec for assemble artifact request #2498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/api/data_types/chunking/artifact.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ use super::ChunkedFileState;
pub struct ChunkedArtifactRequest<'a> {
pub checksum: Digest,
pub chunks: &'a [Digest],
#[serde(skip_serializing_if = "Vec::is_empty")]
pub projects: Vec<String>,
#[serde(skip_serializing_if = "<[_]>::is_empty")]
pub projects: &'a [String],
#[serde(skip_serializing_if = "version_is_empty")]
pub version: Option<&'a str>,
#[serde(skip_serializing_if = "Option::is_none")]
Expand Down
4 changes: 2 additions & 2 deletions src/api/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,7 @@ impl<'a> AuthenticatedApi<'a> {
.with_json_body(&ChunkedArtifactRequest {
checksum,
chunks,
projects: Vec::new(),
projects: &[],
version: None,
dist: None,
})?
Expand All @@ -1015,7 +1015,7 @@ impl<'a> AuthenticatedApi<'a> {
pub fn assemble_artifact_bundle(
&self,
org: &str,
projects: Vec<String>,
projects: &[String],
checksum: Digest,
chunks: &[Digest],
version: Option<&str>,
Expand Down
4 changes: 2 additions & 2 deletions src/utils/file_upload.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ fn poll_assemble(
let response = if use_artifact_bundle {
authenticated_api.assemble_artifact_bundle(
context.org,
vec![context.project.unwrap().to_string()],
&[context.project.unwrap().to_string()],
checksum,
chunks,
context.release,
Expand Down Expand Up @@ -544,7 +544,7 @@ fn upload_files_chunked(
let api = Api::current();
let response = api.authenticated()?.assemble_artifact_bundle(
context.org,
vec![context.project.unwrap().to_string()],
&[context.project.unwrap().to_string()],
checksum,
&checksums,
context.release,
Expand Down