Skip to content

ref(test): Use constant for expected request boundary #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2024
Merged

ref(test): Use constant for expected request boundary #2277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/integration/debug_files/upload.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,13 +289,14 @@ fn ensure_correct_chunk_upload() {
#[test]
/// This test verifies a correct chunk upload of multiple debug files.
fn chunk_upload_multiple_files() {
/// This is the boundary used in the expected request file.
/// It was randomly generated when the expected request was recorded.
const EXPECTED_REQUEST_BOUNDARY: &str = "------------------------b26LKrHFvpOPfwMoDhYNY8";

let expected_chunk_body = fs::read(
"tests/integration/_expected_requests/debug_files/upload/chunk_upload_multiple_files.bin",
)
.expect("expected chunk body file should be present");
// This is the boundary used in the expected request file.
// It was randomly generated when the expected request was recorded.
let boundary_of_expected_request = "------------------------b26LKrHFvpOPfwMoDhYNY8";

let is_first_assemble_call = AtomicBool::new(true);
TestManager::new()
Expand All @@ -316,7 +317,7 @@ fn chunk_upload_multiple_files() {

let expected_chunks = chunk_upload::split_chunk_body(
&expected_chunk_body,
boundary_of_expected_request,
EXPECTED_REQUEST_BOUNDARY,
)
.expect("expected chunk body is a valid multipart/form-data body");

Expand Down
Loading