ref(proguard): Delete pointless code #2263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some code which opens all the proguard files just to compute the SHA1 sum, which is just debug-logged and then added into a vector, which is never read from, and which is not needed for any lifetime purposes. We definitely can get rid of the vector, the debug log is also probably okay to get rid of because this information can easily be obtained using the `sha1sum` command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some code which opens all the proguard files just to compute the SHA1 sum, which is just debug-logged and then added into a vector, which is never read from, and which is not needed for any lifetime purposes. We definitely can get rid of the vector, the debug log is also probably okay to get rid of because this information can easily be obtained using the
sha1sumcommand