Skip to content

Retry file uploads on cloudflare timeout(524) #2707

@manishrawat1992

Description

@manishrawat1992

Problem Statement

Some of the self hosted installations are hosted behind cloudflare. By default, cloudflare proxy_write_timeout is set at 30s. If this timeout is breached, Cloudflare responds with error with status code 524. Currently this is treated as non retriable error by sentry-cli.

https://developers.cloudflare.com/support/troubleshooting/http-status-codes/cloudflare-5xx-errors/error-524/

Solution Brainstorm

Following PR adds status code 524 to retriable status code list. Making sure sentry-cli retries uploads on cloudflare timeout.
Cloudflare timeout happens only in <5% cases, this retry will ensure that artifacts are reliably uploaded to Sentry server.

#2695

Even though it might not mean a lot for the Sentry cloud. It eliminates a lot of problems for the self-hosted users behind cloudflare. sentry-cli is integrated with a lot of SDKs and it is very cumbersome to patch them all. This PR solves those problems in one shot.

Metadata

Metadata

Assignees

No one assigned

    Labels

    CLIProduct areaFeatureIssue type

    Projects

    Status

    Waiting for: Product Owner

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions