Improve geopoint tests #817
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latin-panda
requested changes
Feb 26, 2025
| scenario.answer("/data/q1","1.234 5.678"); | ||
| assertThat(scenario.getAnswerNode("/data/note").isRelevant(), is(false)); | ||
|
|
||
| scenario.answer("/data/q1", "1.234 5.678 0 0"); |
There was a problem hiding this comment.
Suggestion:
- Having a test where the altitude is not zero:
1.234 5.678 0 0 - Having another test where values can produce NaN (e.g. then value is nullable, field is not relevant):
ABC 23.55, PP 0
There was a problem hiding this comment.
@lognaturel, would you prefer to leave this suggestion for another PR?
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests to capture geopoint behavior.
@latin-panda let me know if there are others you think we should add!