enable content search in flexsearch plugin #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was enabled in the past and then accidentally disabled Fixes: 1f1975f
felixfontein
approved these changes
Jan 10, 2026
Contributor
felixfontein
left a comment
felixfontein
left a comment
There was a problem hiding this comment.
I assume you tested this?
Contributor
Author
|
Of course! ;) (I did, really!) |
Contributor
Author
|
the commit that disabled that says "- Commented out content indexing in plugin code but added comprehensive content indexing in JavaScript", but this doesn't seem to work -- as there is no "content" in the generated json, only when you enable the plugin code to add content, then json has it and JS can search |
Contributor
|
In the same code in 1f1975f there's also a lot of usage of |
Contributor
|
Thanks for fixing this @evgeni! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was enabled in the past and then accidentally disabled
Fixes: 1f1975f