Skip to content

feat: Replace pointer-events: none with logic #7581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2025
Merged

feat: Replace pointer-events: none with logic #7581

merged 2 commits into from
Oct 1, 2025

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Sep 5, 2025 •
edited
Loading

Description

Replacing the general pointer-events: none for disabled fields/inputs with very specific rules per field and adding the necessary logic to continue not allowing certain actions when field is disabled.

Changelog

✨ Enhancements

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added this to the 6.0.0-alpha.1 milestone Sep 5, 2025
@distantnative distantnative requested a review from a team September 5, 2025 10:16
@distantnative distantnative self-assigned this Sep 5, 2025
@distantnative distantnative linked an issue Sep 5, 2025 that may be closed by this pull request
pointer-events: none on disabled fields/inputs #7493
Closed
@distantnative distantnative force-pushed the v6/fix/pointer-events-none branch from a0eded4 to e5812c6 Compare September 26, 2025 19:52
@bastianallgeier bastianallgeier force-pushed the v6/fix/pointer-events-none branch from e5812c6 to 4090b58 Compare September 30, 2025 11:31
bastianallgeier
bastianallgeier reviewed Sep 30, 2025
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through all the fields in the lab and the disabled states worked great. There's one tiny exception in the tags field. The plus button still shows up …

Image

@bastianallgeier bastianallgeier force-pushed the v6/fix/pointer-events-none branch from 4090b58 to 83667c2 Compare October 1, 2025 13:27
@bastianallgeier
Copy link
Member

I've fixed the appearing button

@bastianallgeier bastianallgeier self-requested a review October 1, 2025 13:29
@distantnative distantnative merged commit 25f181f into v6/develop Oct 1, 2025
4 checks passed
@distantnative distantnative deleted the v6/fix/pointer-events-none branch October 1, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
6.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.

pointer-events: none on disabled fields/inputs
2 participants
@distantnative @bastianallgeier