This repository was archived by the owner on May 27, 2022. It is now read-only.
Fix assumed "master" as default branch #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nlreturn` checks for a new line before return and branch statements to increase code clarity. This project does not adhere to this convention and fails `make lint` without this change.
fribmendes/geometry changed its default branch to "main", and it no longer has a submodule to test on that branch. The master branch is still there though and has the async submodule to test, so this commit specifies that branch.
Instead of assuming "master" is always the branch we want, these changes allow for taking whatever default branch the GitHub repo specifies. This supports initiatives like the move to "main" as the default branch name.
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
==========================================
+ Coverage 71.82% 72.00% +0.17%
==========================================
Files 12 12
Lines 323 325 +2
==========================================
+ Hits 232 234 +2
Misses 80 80
Partials 11 11
Continue to review full report at Codecov.
|
|
Many thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If applied, this commit will...
This commit addresses issue #369, which describes antibody's default behavior of assuming the "master" branch is the branch desired instead of taking whatever default branch the repo maintainer specifies. Now, instead of hard coding "master", if no branch is specified then
git cloneandgit pullwill not specify a branch either.Why is this change being made?
GitHub is moving towards naming the new default branch "main". This will break antibody without this fix.
Possible regressions to note