Skip to content

Conversation

arnavkirti
Copy link
Contributor

@arnavkirti arnavkirti commented Feb 5, 2025

Closes #156
Closes #163

Copy link

socket-security bot commented Feb 5, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 10.1 kB types
npm/[email protected] None 0 46.5 kB blakeembrey
npm/[email protected] None 0 5.44 kB chancestrickland, mjackson, timdorr
npm/[email protected] network 0 2.28 MB chancestrickland, mjackson, timdorr
npm/[email protected] None 0 16.1 kB nfriedly
npm/[email protected] None 0 54.5 kB jacob-ebey

View full report↗︎

@arnavkirti
Copy link
Contributor Author

This also covers the Issue #156

Copy link
Collaborator

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@rolznz
Copy link
Collaborator

rolznz commented Feb 6, 2025

Thanks for the PR!

Feedback:

  • You can write Closes <issue URL> in the description and Github will automatically link it.
  • You should name your pull request based on the feature you are working on, not your own name
  • You removed some functionality in your change and did not complete all the routes you added to the homepage.
  • You added an empty file for a new connector. I removed it

@rolznz rolznz merged commit 0cf90c5 into getAlby:master Feb 6, 2025
2 checks passed
@arnavkirti
Copy link
Contributor Author

Thank you for the feedback. You said I should name my PR based on the feature I am working on. Does that mean I have to create a branch based on the issue name?

@arnavkirti arnavkirti deleted the arnav branch February 6, 2025 07:57
@rolznz
Copy link
Collaborator

rolznz commented Feb 6, 2025

@arnavkirti have a look at https://conventional-branch.github.io/

it is not a big deal, just a small suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split React demo into separate pages Display memo in payment flow
2 participants