-
Notifications
You must be signed in to change notification settings - Fork 28
Fix the regridding error when the target latitude or longitude is exactly 0.0 #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
yantosca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @1Dandan, this looks good but we just need a CHANGELOG.md update.
yantosca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @1Dandan, good to merge!
This merge brings PR # (Fix the regridding error when the target latitude or longitude is exactly 0.0, by @1Dandan) into the GCPy 1.7.0 development stream. PR #385 updates an if statement to use test for "None" instead of "not", thus avoiding an error when the target latitude or longitude is exactly zero. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
|
NOTE: I forgot to change the base branch. This feature branch has been merged into dev, but the PR will show as merged once we merge dev into main. |
lizziel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
@yantosca, is there anything else this PR needs to merge it in? |
Name and Institution (Required)
Name: Dandan Zhang
Institution: Harvard University
Describe the update
To fix the regridding error when the target latitude or longitude is exactly 0.0
Expected changes
It will work for stretched GCHP regridding when the target latitude or longitude is exactly 0.0.
Reference(s)
N/A
Related Github Issue
#384