Skip to content

Conversation

cehbrecht
Copy link
Collaborator

Overview

The PR changes the initialization of a default value.

  • A default value will only be set when min_occurs==0.
  • When a default value is configured and min_occurs>=1 a warning will be shown in the log.

Related Issue / Discussion

#625

Additional Information

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • [x ] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

@cehbrecht cehbrecht requested a review from huard September 29, 2021 16:09
@cehbrecht
Copy link
Collaborator Author

@fmigneault Please have a look at this PR. When accepted I can backport it also to 4.4.x.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling a063626 on cehbrecht:fix-min-occurs into 584f792 on geopython:main.

@cehbrecht cehbrecht merged commit 793ab34 into geopython:main Sep 30, 2021
@cehbrecht cehbrecht deleted the fix-min-occurs branch September 30, 2021 12:30
cehbrecht added a commit to cehbrecht/pywps that referenced this pull request Sep 30, 2021
* ignore default when a value is required

* fixed test
cehbrecht added a commit that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants