Move InversseVelocityBlock to a header file for block Stokes preconditioning and add template arguments for vector/matrix type. #6711
+141
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quangx
force-pushed
the
gmg_preconditioner
branch
from
4cb9ca7 to
4f98075
Compare
|
is this ready to go, @quangx ? |
tjhei
approved these changes
Oct 13, 2025
Comment on lines
33
to
34
| * This operator can either just apply the preconditioner (AMG) | ||
| * or perform an inner CG solve with the same preconditioner. |
There was a problem hiding this comment.
Suggested change
| * This operator can either just apply the preconditioner (AMG) | |
| * or perform an inner CG solve with the same preconditioner. | |
| * This operator can either just apply the preconditioner | |
| * or perform an inner CG / BiCGStab solve with the same preconditioner. |
Comment on lines
44
to
48
| * @param do_solve_A A flag indicating whether we should actually solve with | ||
| * the matrix $A$, or only apply one preconditioner step with it. | ||
| * @param A_block_is_symmetric A flag indicating whether the matrix $A$ is symmetric. | ||
| * @param A_block_tolerance The tolerance for the CG solver which computes | ||
| * the inverse of the A block. |
tjhei
reviewed
Oct 13, 2025
| * @param do_solve_A A flag indicating whether we should actually solve with | ||
| * the matrix $A$, or only apply one preconditioner step with it. | ||
| * @param A_block_is_symmetric A flag indicating whether the matrix $A$ is symmetric. | ||
| * @param A_block_tolerance The tolerance for the CG solver which computes |
There was a problem hiding this comment.
Suggested change
| * @param A_block_tolerance The tolerance for the CG solver which computes | |
| * @param solver_tolerance The tolerance for the CG solver which computes |
quangx
force-pushed
the
gmg_preconditioner
branch
from
c893790 to
0a35ab6
Compare
quangx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of restructuring the code is to use the same preconditioner class for AMG and GMG. Moving the InverseVelocityBlock to a header file and adding template arguments for vector/matrix should help with achieving that.