Skip to content

Conversation

naliboff
Copy link
Contributor

@naliboff naliboff commented Apr 7, 2025

An initial step towards adding the option to use the multicomponent_compressible EOS in the visco_plastic material model. In theory no functionality has changed with the initial commit and the goal is to see if all the tests pass.

@gassmoeller - two questions:

  1. Following our initial conversation, does this structure look reasonable, or is there a more streamlined way to switch between the two EOS modules?
  2. multicomponent_compressible currently does not support having more than one phase. Should I add this functionality to multicomponent_compressible first before proceeding with PR, or introduce logic internally within visco_plastic to handle this discrepancy?

For all pull requests:

@gassmoeller
Copy link
Member

Hi John,
Yes unfortunately there is currently no nicer way to implement this, but please make the input parameter a bit more future-proof, e.g. by naming it Equation of state and only allow the options multicomponent compressible and multicomponent incompressible for now. This way we can change the internal implementation later without having to change the input parameter.

@naliboff naliboff force-pushed the enable_compressibility_visco_plastic branch from 64bcaae to 396198a Compare June 10, 2025 17:03
@naliboff naliboff force-pushed the enable_compressibility_visco_plastic branch from 396198a to aa2b9fc Compare June 10, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants